Fix node selector argument #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Going to merge this in and get a release built for it. Sorry for the delay on all this, the virus has caused my daytime workload to get crazy! |
|
Great, thanks @mwthink. No worries on the delay - stay safe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Hey @mwthink, I know you were planning to re-write this, but I'd really appreciate a quick fix if possible, as I need this to finalise my setup.
This should fix the problem - the input is
NODE_SELECTORstill. If this is not set, then we simply append nothing to the end of theapi/v1/nodesendpoint. Otherwise, we append?labelSelector=${NODE_SELECTOR}to the endpoint.If there any chance you could take a look? Thanks!