Skip to content

Commit

Permalink
Merge pull request #74 from mxcl/node16
Browse files Browse the repository at this point in the history
Migrate to Node 16 LTS
  • Loading branch information
chris-araman authored Dec 13, 2021
2 parents ee0c3fc + fd17e2d commit 7375a11
Show file tree
Hide file tree
Showing 9 changed files with 199 additions and 283 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,4 +271,4 @@ This action does not support Windows.
[secrets]: https://docs.github.com/en/actions/reference/encrypted-secrets
[export]: https://docs.github.com/en/actions/guides/installing-an-apple-certificate-on-macos-runners-for-xcode-development#creating-secrets-for-your-certificate-and-provisioning-profile

![Analytics](https://repobeats.axiom.co/api/embed/d18c74fbcc8431bca3d0dd76cc3131c32df24dce.svg "Repobeats analytics image")
![Analytics](https://repobeats.axiom.co/api/embed/d18c74fbcc8431bca3d0dd76cc3131c32df24dce.svg 'Repobeats analytics image')
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ inputs:
default: on-failure
required: false
runs:
using: 'node12'
using: 'node16'
main: 'dist/index.js'
post: 'dist/index.js'
post-if: runner.os == 'macOS'
4 changes: 2 additions & 2 deletions dist/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/sourcemap-register.js

Large diffs are not rendered by default.

440 changes: 184 additions & 256 deletions package-lock.json

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
"semver": "^7.3.5"
},
"devDependencies": {
"@tsconfig/node12": "^1.0.9",
"@types/node": "^12.20.36",
"@tsconfig/node16": "^1.0.2",
"@types/node": "^16.11.11",
"@types/semver": "^7.3.9",
"@typescript-eslint/eslint-plugin": "^5.2.0",
"@typescript-eslint/parser": "^5.2.0",
"@vercel/ncc": "^0.31.1",
"eslint": "^8.1.0",
"@typescript-eslint/eslint-plugin": "^5.5.0",
"@typescript-eslint/parser": "^5.5.0",
"@vercel/ncc": "^0.32.0",
"eslint": "^8.3.0",
"eslint-config-prettier": "^8.3.0",
"prettier": "2.4.1",
"typescript": "^4.4.4"
"prettier": "2.5.0",
"typescript": "^4.5.2"
}
}
12 changes: 0 additions & 12 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,6 @@ import * as fs from 'fs'
import * as path from 'path'
import semver, { Range } from 'semver'

// Unhandled promise rejections don't terminate the process by default until node 15.
// GitHub Actions run in node 12, and we don't have a way to pass --unhandled-rejections=strict.
// [https://github.com/mxcl/xcodebuild/issues/53]
if (semver.lt(process.version, '15.0.0')) {
process.on('unhandledRejection', (reason, promise) => {
core.error(
`internal error: unhandled rejection at: ${promise}, reason: ${reason}`
)
process.exit(1)
})
}

//TODO we also need to set the right flags for other languages
const warningsAsErrorsFlags = 'OTHER_SWIFT_FLAGS=-warnings-as-errors'

Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node12/tsconfig.json",
"extends": "@tsconfig/node16/tsconfig.json",
"compilerOptions": {
"noImplicitAny": true,
"moduleResolution": "node"
Expand Down

0 comments on commit 7375a11

Please sign in to comment.