Add explicit audio converters to voice processor and echo probe #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VoiceProcessor and EchoProbe plugins have fixed caps: rate=48000,channels=1. There is no such cap on windows, hence append explicit resampler and converter.
igsha
force-pushed
the
feat-voice-processor
branch
from
6e00e09 to
f742898
Compare
mxlgv
approved these changes
Apr 17, 2024
kkonsw
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sample rate and audio format conversion for VoiceProcessor and EchoProbe. This is necessary because the microphone or speakers may not have a 48kHz sampling rate. For example, on Bluetooth headphones on a Mac the sampling frequency is no longer 16 kHz, on Windows in wasapi it is 44.1 kHz. This will be useful to avoid any problems with unknown microphones and headphones.