Fix Dino does not refresh expired TURN\STUN server credentials #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giantplaceholder
changed the title
giantplaceholder
changed the title
VadimNk
force-pushed
the
xep-0215-expires
branch
from
ffd3988 to
1a47f01
Compare
Add a field in `Xmpp.Xep.ExternalServiceDiscovery` to keep track of the `expires` TURN service value and use it (divided by 2) to restart periodically the external services discovery.
Fix following comment and recommandations: - Use DateTime? type instead of int64? - check the computed delay value against sane values - use a HashMap to keep track of timers and cancel them on connection closed - add equals and hash funcs to XmppStream to use with the HashMap - rename the callback to reflect its meaning - test the TURN server conf before STUN default server
VadimNk
force-pushed
the
xep-0215-expires
branch
from
a3d1f68 to
e10c263
Compare
vlomovtsev
approved these changes
Apr 24, 2024
|
After a 24-hour test, audio dialing is successful and the sound goes in both directions. In the original PR, after a network reconnection there was no sound from the 24 hour client. |
mxlgv
approved these changes
Apr 24, 2024
mxlgv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a field in Xmpp.Xep.ExternalServiceDiscovery to keep track of the expires TURN service value and use it (divided by 2) to restart periodically the external services discovery.
Without this patch, calls (actually ICE) fail to initiate after 24h of Dino uptime because of the expiry of the TURN credentials.
This happened on my setup using prosody (using the default credentials' TTL of 86400) and coturn.