Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Add Native 1.2 Support #20

Closed
dbemiller opened this issue Feb 16, 2018 · 11 comments
Closed

Add Native 1.2 Support #20

dbemiller opened this issue Feb 16, 2018 · 11 comments
Milestone

Comments

@dbemiller
Copy link
Contributor

It looks like the latest version of OpenRTB Native 1.2 has been released: https://iabtechlab.com/wp-content/uploads/2016/07/OpenRTB-Native-Ads-Specification-Final-1.2.pdf

There are a few more fields in this version which could be added to the project.

@mxmCherry
Copy link
Owner

mxmCherry commented Feb 18, 2018

I'll definitely take a look over the next weekend (Feb 24-25). But PRs are welcome at any time :)

@dbemiller
Copy link
Contributor Author

dbemiller commented Feb 20, 2018

sure thing! I'll start some of it this week if I have time, but... can't promise anything. I've got a few pull requests on my own project which I've been neglecting for a while already.

@mxmCherry
Copy link
Owner

Started #21

@mxmCherry
Copy link
Owner

mxmCherry commented Feb 25, 2018

I was really surprised by how badly that 1.2 spec is done.

First - no (working) links in PDF.

Then some inconsistencies for new type(s):

  • starting with really minor "type: text" instead of usual "type: string" in 5.8 Event Tracker Response Object - "url" field description
  • proceeding (ending?) with really frustrating 5.8 Event Tracker Response Object - "customdata" field: "type: object containing key:value pairs" and "description: ... an array of
    key:value objects ..." (luckily, that doesn't matter for implementation, as it's better done as RawJSON)

I didn't expect good quality from these docs, but it outperformed my expectations.

Then I decided to check https://www.iab.com/guidelines/real-time-bidding-rtb-project/

(drumroll...)

Native 1.2 is still Draft for Public Review (just with review period ended on May 17, 2017), it's not released yet 😄

And it looks like ad-tech world (including it's authors) ignored it (I have no other explanation for poor document's state since May 2017).

Anyway, I've almost done it #21 , I'll, probably, finish it till next Monday (Mar 6).

But I'm not sure I would like to merge it into master until it's officially released. Probably, I'll merge, but I don't promise anything. Probably, if prebid-server really needs it (does it?), we could make/keep dedicated native-1.2-dev branch.

Does any exchange support it already? (I'd expect none yet, but haven't followed Native news for quite a while)

@mxmCherry
Copy link
Owner

Though document name has Final in it 🤔 But I'd defo better wait till it's linked from some "official" page.

@dbemiller
Copy link
Contributor Author

dbemiller commented Feb 26, 2018

yeesh.... you're right.

As far as official pages go, it is linked from here. ...but I notice that there's no "Release date" on it, the way there is for the other versions.

This blog post also looks official, and mentions that the Native group went on hiatus right afterwards. Maybe the native group "finalized" it, but the "core" IAB group disliked it so much that they never released it?

I'll poke around some slack channels and get back to you. There's got to be someone connected to the IAB who can give us the story.

Def don't feel obligated to merge it or keep a dedicated branch for it just for us... we've got the same goal here. If it's not yet official, it shouldn't be in prebid-server either.

@dbemiller
Copy link
Contributor Author

I asked in the reddit adops slack channel. Jennifer Derke confirmed that Native 1.2 is official and finalized, and the iab.com link needs to be updated. She also said that a few companies have started implementing it.

She's the product director of the IAB Tech Lab, so... should be a fair authority ^^.

@mxmCherry
Copy link
Owner

@dbemiller thanks a lot, will merge when it's done (tests/docs/final review left) then.

@mxmCherry mxmCherry added this to the v10.0.0 milestone Mar 2, 2018
@mxmCherry
Copy link
Owner

Pubished on https://www.iab.com/guidelines/real-time-bidding-rtb-project/ page:

https://www.iab.com/wp-content/uploads/2018/03/OpenRTB-Native-Ads-Specification-Final-1.2.pdf

For now - will add this link to repo docs.

Though https://iabtechlab.com/ looks to be more suitable resource to reference OpenRTB specs ¯_(ツ)_/¯

@mxmCherry
Copy link
Owner

#21 merged

@mxmCherry
Copy link
Owner

Released as v10.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants