This repository has been archived by the owner on Oct 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mxmCherry
changed the title
Native 1.2: 4.1 Native Markup Request Object reviewed
Native 1.2
Feb 25, 2018
Reviewed request/response types once again, no fields seems to be missing. Haven't reviewed enum values carefully, but these can be fixed later, if anything changed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready yet, submitting pull request just to track progress.
OpenRTB Dynamic Native Ads API Specification Version 1.2 implementation
4.1 Native Markup Request Object
4.2 Asset Request Object
4.3 Title Request Object
4.4 Image Request Object
4.5 Video Request Object
4.6 Data Request Object
4.7 Event Trackers Request Object
5.1 Native Markup Response Object
5.2 Asset Response Object
5.3 Title Response Object
5.4 Image Response Object
5.5 Data Response Object
5.6 Video Response Object
5.7 Link Response Object
5.8 Event Tracker Response Object
7.6 Event Types Table
7.7 Event Tracking Methods Table
move enums from
native/{request,response}.*
->native.*
update test files, if they're updated in spec
update docs (README etc)
review / double check everything again