Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Native 1.2 #21

Merged
merged 18 commits into from
Mar 3, 2018
Merged

Native 1.2 #21

merged 18 commits into from
Mar 3, 2018

Conversation

mxmCherry
Copy link
Owner

@mxmCherry mxmCherry commented Feb 20, 2018

Not ready yet, submitting pull request just to track progress.

OpenRTB Dynamic Native Ads API Specification Version 1.2 implementation

  • 4.1 Native Markup Request Object

  • 4.2 Asset Request Object

  • 4.3 Title Request Object

  • 4.4 Image Request Object

  • 4.5 Video Request Object

  • 4.6 Data Request Object

  • 4.7 Event Trackers Request Object

  • 5.1 Native Markup Response Object

  • 5.2 Asset Response Object

  • 5.3 Title Response Object

  • 5.4 Image Response Object

  • 5.5 Data Response Object

  • 5.6 Video Response Object

  • 5.7 Link Response Object

  • 5.8 Event Tracker Response Object

  • 7.6 Event Types Table

  • 7.7 Event Tracking Methods Table

  • move enums from native/{request,response}.* -> native.*

  • update test files, if they're updated in spec

  • update docs (README etc)

  • review / double check everything again

@mxmCherry mxmCherry mentioned this pull request Feb 20, 2018
@mxmCherry mxmCherry changed the title Native 1.2: 4.1 Native Markup Request Object reviewed Native 1.2 Feb 25, 2018
@mxmCherry mxmCherry self-assigned this Mar 2, 2018
@mxmCherry mxmCherry added this to the v10.0.0 milestone Mar 2, 2018
@mxmCherry
Copy link
Owner Author

Reviewed request/response types once again, no fields seems to be missing.

Haven't reviewed enum values carefully, but these can be fixed later, if anything changed.

@mxmCherry mxmCherry merged commit c426d33 into master Mar 3, 2018
@mxmCherry mxmCherry deleted the feature/native-1.2 branch March 3, 2018 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant