This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Make native response asset ID a pointer #45

Merged

mxmCherry merged 1 commit into mxmCherry:master from rokostik:native_asset_id_pointer

Apr 12, 2021

Contributor

rokostik commented Apr 12, 2021

As mentioned in #44 an ID with a zero value is lost when marshalling.
This PR makes it into a pointer to avoid the issue.


          make native response asset id a pointer

e567409

Owner

mxmCherry commented Apr 12, 2021

Having 0 asset ID seems weird to me, but OK - request asset ID description says:

Unique asset ID, assigned by exchange. Typically a counter for the array.

(OpenRTB Native 1.2)

Merging and will release as next major version.

Thanks for PR-ing.

mxmCherry merged commit 0561c56 into mxmCherry:master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet