perf: improve UX for default resources config

changed `LOCALSANDBOX_DISABLE_DEFAULT_RESOURCES` to `LOCALSANDBOX_DEFAULT_RESOURCES`
mxsdev · Sep 20, 2024 · 12a7e64 · 12a7e64
1 parent 886e301
commit 12a7e64
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/packages/csharp-test/AzureTests.cs b/packages/csharp-test/AzureTests.cs
@@ -70,7 +70,7 @@ protected async Task<string> CreateQueue(int? maxDeliveryCount = null, TimeSpan?
         }
         else
         {
-            var queue = await serviceBusManagementClient.Value.Queues.CreateOrUpdateAsync(rg, ns, Guid.NewGuid().ToString(), new()
+            var queue = await serviceBusManagementClient.Value.Queues.CreateOrUpdateAsync(resourceGroupName: rg, namespaceName: ns, queueName: Guid.NewGuid().ToString(), new()
             {
                 MaxDeliveryCount = maxDeliveryCount,
                 AutoDeleteOnIdle = autoDeleteOnIdle ?? TimeSpan.FromMinutes(10),
@@ -155,7 +155,7 @@ public AzureTests()
         serviceBusManagementClient = new(() => new ServiceBusManagementClient(new TokenCredentials(subscriptionId))
         {
             SubscriptionId = subscriptionId,
-            BaseUri = !e2eMode ? new Uri($"https://localhost.localsandbox.sh:7329/azure") : null
+            BaseUri = !e2eMode ? new($"https://localhost.localsandbox.sh:7329/azure") : null
         });
     }
 

diff --git a/src/cli/index.ts b/src/cli/index.ts
@@ -65,9 +65,9 @@ const getEnvironmentVariableHelp = (
 }
 
 const server_help = getEnvironmentVariableHelp({
-  LOCALSANDBOX_DISABLE_DEFAULT_RESOURCES: {
-    help: "Disable creation of default resources",
-    default: "false",
+  LOCALSANDBOX_DEFAULT_RESOURCES: {
+    help: "Enable creation of default resources",
+    default: "true",
   },
 
   LOCALSANDBOX_DEFAULT_LOCATION: {

diff --git a/src/lib/integration/azure/index.ts b/src/lib/integration/azure/index.ts
@@ -22,7 +22,7 @@ export const createAzureIntegration: IntegrationFactory<
   const build = azure_routes.build()
 
   if (
-    !env.LOCALSANDBOX_DISABLE_DEFAULT_RESOURCES &&
+    env.LOCALSANDBOX_DEFAULT_RESOURCES &&
     env.LOCALSANDBOX_DEFAULT_SUBSCRIPTION_ID
   ) {
     logger?.debug(

diff --git a/src/lib/server/env.ts b/src/lib/server/env.ts
@@ -19,10 +19,10 @@ const envSchema = z.object({
   LOCALSANDBOX_DEFAULT_LOCATION: z.string().optional().default("westus2"),
 
   LOCALSANDBOX_DEFAULT_SUBSCRIPTION_ID: resource_name,
-  LOCALSANDBOX_DISABLE_DEFAULT_RESOURCES: z.coerce
+  LOCALSANDBOX_DEFAULT_RESOURCES: z.coerce
     .string()
     .optional()
-    .default("false")
+    .default("true")
     .transform((v) => v.toLowerCase() === "true" || v === "1"),
   LOCALSANDBOX_DEFAULT_RESOURCE_GROUP: resource_name,
   LOCALSANDBOX_DEFAULT_NAMESPACE: resource_name,