Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose n_ubatch and dynamically adjust ntokens for bench #104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: expose n_ubatch and dynamically adjust ntokens for bench #104

wants to merge 2 commits into from

Conversation

a-ghorbani
Copy link
Contributor

This PR introduces the following changes:

  • Expose n_ubatch: Allows applications/users to modify n_ubatch as needed.
  • Dynamic ntokens for bench: Previously, the ntokens value for bench was hardcoded to 512. This is now dynamically set to min(pp, n_ubatch), allowing more flexibility for benchmarking scenarios.

@a-ghorbani a-ghorbani changed the title [Feat] Expose n_ubatch and dynamically adjust ntokens for bench feat: expose n_ubatch and dynamically adjust ntokens for bench Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@a-ghorbani