Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Certificate and SNIs #102

Merged
merged 1 commit into from
Feb 4, 2018
Merged

Conversation

CyExy
Copy link
Contributor

@CyExy CyExy commented Nov 19, 2017

This should do the trick. It would be helpful to get some feedback.

closes #73

  • Fix < 0.10 kong compat
certificates:
  - ensure: present
    cert: >-
      -----BEGIN CERTIFICATE-----
      MIIDMjCCAhqgAwIBAgIJAPgRdnOdnX/SMA0GCSqGSIb3DQEBBQUAMBoxGDAWBgNV
      ....
    key: >-
      -----BEGIN RSA PRIVATE KEY-----
      MIIEpAIBAAKCAQEAo5BpOQY2AV/1L2QEdSip75rHh3Khs2knNtMLIrP26MHyidtX
      ....
    snis:
      - name: example.com
        ensure: present
      - name: www.example.com
        ensure: present

@bspaans
Copy link

bspaans commented Dec 1, 2017

I build kongfig into my kong Docker images using npm so I don't have the right infrastructure in place to test this atm, but I wouldn't mind trying it out, because it'd be great to see this merged. I would need to spend some time to setup the build inside my Docker container unless you know of a better way to get this using npm?

@lcasassa
Copy link

lcasassa commented Jan 15, 2018

Any update on this? Solving merge conflicts was quite easy. I just tested it and it works great! I would love to see this on the official npm package. How can I help?

@CyExy
Copy link
Contributor Author

CyExy commented Jan 15, 2018

Thanks for testing it. Have got a little bogged down with work but will get this and other bits into the next release that's going to be this week. Sorry for the delay.

@CyExy CyExy force-pushed the add-certificate-support branch from 1429aca to 1e9658b Compare January 22, 2018 23:32
@lcasassa
Copy link

lcasassa commented Feb 4, 2018

Don't be sorry. Thanks for all the hard work and time you put into this. This project is awesome! 👍

@CyExy CyExy force-pushed the add-certificate-support branch from 1e9658b to e6aa1aa Compare February 4, 2018 17:03
@CyExy CyExy merged commit 76a27e7 into master Feb 4, 2018
@CyExy CyExy deleted the add-certificate-support branch February 4, 2018 17:16
@bspaans
Copy link

bspaans commented Feb 22, 2018

Hi, I also finally got a chance to test it and it's looking good. Thanks a lot! Would it be possible to get this into a npm release soon?

@CyExy
Copy link
Contributor Author

CyExy commented Feb 28, 2018

@bspaans finally released on NPM [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for certificates and SNI
3 participants