Added pagination of consumers, plus check for non array #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added check for array or not.
|
@CyExy let me know if this is the repo style as well. |
vl4d
changed the title
|
Sorry for a late response, couldn't respond because I was on a holiday. This looks good to me |
|
Awesome, will clean it up and let you know. |
- Also added checks to ensure variable is an array before using "some" function
|
@CyExy functionality should be the same feel free to review, test and merge when comfortable. |
|
@vl4d Great work, thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially for #30
Please review. After you give the go ahead I will implement the caching much like getJson in adminApi.js
I have tested on a kong v: 0.8.0 with 500 + consumers.
May solve: #43 #33 #32