refactor: upgrade cache logic to vendir 0.38.0 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lify our own cache logic and make it more granular to operate on vendir.yaml directory level
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #147 +/- ##
==========================================
+ Coverage 54.33% 54.58% +0.24%
==========================================
Files 23 23
Lines 2341 2325 -16
==========================================
- Hits 1272 1269 -3
+ Misses 874 862 -12
+ Partials 195 194 -1 ☔ View full report in Codecov by Sentry. |
fritzduchardt
changed the title
fritzduchardt
changed the title
Zebradil
reviewed
Dec 20, 2023
internal/myks/util.go
Outdated
| @@ -321,6 +321,15 @@ func isExist(path string) (bool, error) { | |||
| return false, err | |||
| } | |||
|
|
|||
| func isExistsSloppy(path string) bool { | |||
There was a problem hiding this comment.
I'm puzzled by the purpose of this function. I have two points to that:
- If you don't want to do error handling in the client code, you can use the following:
exists, _ := isExists(path)
- However, I'd suggest against that.
ErrNotExistis not the only possible error; in case of other errors, you probably want to be aware of them. (Example)
Zebradil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the improved handling of lock files in vendir 0.38.0 we can simplify our own cache logic and make it more granular to operate on vendir.yaml directory level