Parse a self-closing tag with no attributes and no space before '/>' #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore '/>'. Add '<there/>' example to the test suite. Update the tests for version 4.2 to 5 of elm-test. No more Main.elm. Remove elm-doc-test installation and use. There aren't any doc tests, and it was generating files that didn't compile on my machine.
|
Is anybody there? |
|
Sorry, I just forgot about this issue! |
|
I believe you can just merge my changes, and the new commit on your repository will automatically get included in your existing pull request on eeue56/elm-xml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
myrho's update worked, but didn't pass the Travis CL tests, due to the incompatible changes to elm-test. I made a tiny change to the parser, to properly parse
<foo/>, and updated the test environment to work with the latest elm-test (version 4.2 to 5.0).We'll see if Travis CL is happy with it after myrho merges and that merge gets applied to his pull request in the main eeu56 repository.
I moved the 2.2.3 tag to my commit, so if it passes tests, and Noah is happy with it, it should be ready to "elm package publish".