Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor code cleanup #406

Merged
merged 12 commits into from
Feb 28, 2024
Merged

Minor code cleanup #406

merged 12 commits into from
Feb 28, 2024

Conversation

DominykasPetke
Copy link

Fixed

  • A bug in recent commits where MemoryWrite would go to the wrong target
  • Temperature reading in the LMS GUI

Changed

  • A couple of C-style arrays to std::arrays
  • An "is directory" check and creating it if it doesn't exist to use std::filesystem
  • Cleaned up some double spaces in strings

Removed

  • Unused CMake parameter from GitHub Actions
  • Class declarations for classes that don't exist anymore

@rjonaitis rjonaitis merged commit 1f8b2c6 into myriadrf:litepcie-update Feb 28, 2024
5 checks passed
@DominykasPetke DominykasPetke deleted the litepcie-update-c-cleanup branch February 28, 2024 10:03
DominykasPetke pushed a commit to Matom-ai/LimeSuite that referenced this pull request Mar 28, 2024
@rjonaitis
Merge pull request myriadrf#406 from Matom-ai/litepcie-update-c-cleanup
7270d7f 
Minor code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominykasPetke @rjonaitis