Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract style checker from build jobs #76

Closed
myselfhimself opened this issue Nov 4, 2020 · 2 comments
Closed

Extract style checker from build jobs #76

myselfhimself opened this issue Nov 4, 2020 · 2 comments
Assignees
@myselfhimself

Comments

@myselfhimself
Copy link
Owner

Pointed out by @Czaki on pypa/cibuildwheel#329
@myselfhimself myselfhimself self-assigned this Nov 4, 2020
@Czaki
Copy link

Czaki commented Nov 4, 2020

Github actions allow adding dependency between steps
see https://github.com/4DNucleome/PartSeg/blob/master/.github/workflows/tests.yml

So you could add a check in the first step, and then if this check fail no build step is executed.

myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
61d524b 
…ck into separate job
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
1102ceb 
…ck into separate job(2)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
bb18ad9 
…ck into separate job(3)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
fcb1e61 
…ck into separate job(4)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
ae52ef2 
…ck into separate job(5)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
fc8e289 
…ck into separate job(6)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
de02c54 
…ck into separate job(7)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
fcacfc3 
…ck into separate job(8)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
9189d2a 
…ck into separate job(9)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
a22eaa9 
…ck into separate job(10)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
14c4f78 
…ck into separate job(11)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
fd7da62 
…ck into separate job(12)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
583af83 
…ck into separate job(13)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
5932631 
…ck into separate job(14)
myselfhimself added a commit that referenced this issue Dec 14, 2020
@myselfhimself
#43 #76 rewriting non-tag-push job blocker, separating code style che…
25aeb51 
…ck into separate step(14)
@myselfhimself
Copy link
Owner Author

@Czaki thank you.. I confused jobs and steps for isolating this code style part. Unfortunately Github Action does not allow for sub-workflow mutualisation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myselfhimself myselfhimself

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@myselfhimself @Czaki