Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requirements for redeeming link to email change confirmation mail. #4422

Merged
merged 1 commit into from
May 11, 2023
Merged

Add requirements for redeeming link to email change confirmation mail. #4422

merged 1 commit into from
May 11, 2023

Conversation

neprune
Copy link
Contributor

@neprune neprune commented May 9, 2023

No description provided.

@neprune neprune force-pushed the add-requirements-to-change-email-confirmation-mail branch from 4e26b36 to 2212ce3 Compare May 9, 2023 10:01
@codecov
Copy link

codecov bot commented May 9, 2023 •
edited
Loading

Codecov Report

Merging #4422 (bd48369) into master (d74dba8) will decrease coverage by 4.86%.
The diff coverage is n/a.

❗ Current head bd48369 differs from pull request most recent head 251d907. Consider uploading reports for the commit 251d907 to get more accurate results

@@            Coverage Diff             @@
##           master    #4422      +/-   ##
==========================================
- Coverage   75.38%   70.52%   -4.86%     
==========================================
  Files         359       41     -318     
  Lines       27450     4750   -22700     
  Branches     4269        0    -4269     
==========================================
- Hits        20692     3350   -17342     
+ Misses       5420     1400    -4020     
+ Partials     1338        0    -1338

see 319 files with indirect coverage changes

@neprune neprune marked this pull request as ready for review May 9, 2023 10:53
@neprune neprune requested review from dracos and davea May 9, 2023 10:53
@neprune neprune changed the title Add requirement details to change email confirmation mail. Add requirement details to email change confirmation mail. May 9, 2023
@neprune neprune removed request for davea and dracos May 9, 2023 10:54
@neprune neprune marked this pull request as draft May 9, 2023 10:54
@neprune neprune force-pushed the add-requirements-to-change-email-confirmation-mail branch from 2212ce3 to 251d907 Compare May 9, 2023 10:56
@neprune neprune marked this pull request as ready for review May 9, 2023 10:58
@neprune neprune requested review from dracos and davea May 9, 2023 10:58
@neprune neprune changed the title Add requirement details to email change confirmation mail. Add requirements for redeeming link to email change confirmation mail. May 9, 2023
@neprune neprune force-pushed the add-requirements-to-change-email-confirmation-mail branch from 251d907 to a6620b7 Compare May 11, 2023 06:39
@neprune neprune merged commit a6620b7 into master May 11, 2023
@neprune neprune temporarily deployed to github-pages May 11, 2023 06:40 — with GitHub Pages Inactive
@neprune neprune deleted the add-requirements-to-change-email-confirmation-mail branch June 19, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dracos dracos dracos approved these changes

@davea davea Awaiting requested review from davea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neprune @dracos