Allow cobrands to customise nearby lookup distances for duplicates #4456
Conversation
davea
force-pushed
the
duplicate-distance-cobrand-feature
branch
2 times, most recently
from
f65a1b2 to
3e0576a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4456 +/- ##
==========================================
- Coverage 82.20% 82.19% -0.01%
==========================================
Files 365 365
Lines 27647 27653 +6
Branches 4293 4294 +1
==========================================
+ Hits 22727 22730 +3
- Misses 3630 3633 +3
Partials 1290 1290
|
| @@ -679,10 +679,14 @@ sub _nearby_json :Private { | |||
| $c->stash->{page} = 'report'; | |||
|
|
|||
| # distance in metres | |||
| my $dist = $c->get_param('distance') || ''; | |||
| my $dist; | |||
| if (my $mode = $c->get_param('mode')) { | |||
There was a problem hiding this comment.
Given there are two different endpoints for the two different modes, can we set 'mode' in the controllers that then call _nearby_json rather than a query parameter?
There was a problem hiding this comment.
Suppose we could, but there's currently nothing inspector- or suggestions-specific about the behaviour of the two different paths. I think I'd prefer to leave them as-is with the intention of each call made explicit rather than adding some subtle difference in behaviour of two very similarly named things that'd trip somebody up in the future (most likely me!)
For UK councils this is picked up from cobrand feature config. For FD-2997.
davea
force-pushed
the
duplicate-distance-cobrand-feature
branch
from
3e0576a to
854323a
Compare
For UK councils this is picked up from cobrand feature config.
For FD-2997.