Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Buckinghamshire] Allow templates in same category, different code. #4497

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

dracos
Copy link
Member

@dracos dracos commented Jun 28, 2023

As Bucks can set both state and external status code (for email updates), need to check differently. Use a cobrand variable. [skip changelog] Fixes FD-3138.

Plus a fix for apostrophe in category name noticed in FD-3141.

@dracos dracos requested a review from davea June 28, 2023 11:36
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #4497 (47ddeb0) into master (042257f) will decrease coverage by 15.23%.
The diff coverage is n/a.

❗ Current head 47ddeb0 differs from pull request most recent head fab9fc8. Consider uploading reports for the commit fab9fc8 to get more accurate results

@@             Coverage Diff             @@
##           master    #4497       +/-   ##
===========================================
- Coverage   85.02%   69.79%   -15.23%     
===========================================
  Files         330       41      -289     
  Lines       23133     4890    -18243     
  Branches     4363        0     -4363     
===========================================
- Hits        19668     3413    -16255     
+ Misses       2165     1477      -688     
+ Partials     1300        0     -1300     

see 371 files with indirect coverage changes

@dracos dracos force-pushed the issues/freshdesk/3138-bucks-sc-codes-same-state branch 3 times, most recently from aa812d6 to 1733241 Compare June 29, 2023 14:37
dracos added 2 commits June 29, 2023 17:35
As Bucks can set both state and external status code (for email
updates), need to check differently. Use a cobrand variable.
@dracos dracos force-pushed the issues/freshdesk/3138-bucks-sc-codes-same-state branch from 1733241 to fab9fc8 Compare June 29, 2023 16:48
@dracos dracos merged commit fab9fc8 into master Jun 30, 2023
@dracos dracos temporarily deployed to github-pages June 30, 2023 08:12 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants