Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for requiring a phone number for particular categories. #4520

Closed
wants to merge 0 commits into from
Closed

Add support for requiring a phone number for particular categories. #4520

wants to merge 0 commits into from
+0 −0

Conversation

neprune
Copy link
Contributor

@neprune neprune commented Jul 16, 2023

@neprune neprune changed the base branch from master to cbd-jadu-reviewed July 16, 2023 14:01
@neprune neprune force-pushed the cbd-jadu-require-phone branch from 5e071f1 to 5cf129f Compare July 16, 2023 14:02
@codecov
Copy link

codecov bot commented Jul 16, 2023 •
edited
Loading

Codecov Report

Merging #4520 (2d2c46d) into cbd-jadu-reviewed (76f67b0) will increase coverage by 1.21%.
The diff coverage is 38.88%.

❗ Current head 2d2c46d differs from pull request most recent head db2c993. Consider uploading reports for the commit db2c993 to get more accurate results

@@                  Coverage Diff                  @@
##           cbd-jadu-reviewed    #4520      +/-   ##
=====================================================
+ Coverage              69.02%   70.23%   +1.21%     
=====================================================
  Files                    359       42     -317     
  Lines                  27147     4952   -22195     
  Branches                4174        0    -4174     
=====================================================
- Hits                   18737     3478   -15259     
+ Misses                  7179     1474    -5705     
+ Partials                1231        0    -1231
Impacted Files Coverage Δ
web/cobrands/fixmystreet/fixmystreet.js 77.16% <38.88%> (-0.50%) ⬇️

... and 318 files with indirect coverage changes

@neprune neprune requested a review from dracos July 16, 2023 14:16
dracos
dracos requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, needs a bit more work for the logged out use.

@neprune neprune requested a review from dracos July 17, 2023 15:22
dracos
dracos requested changes Jul 18, 2023
View reviewed changes
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think (though feel free to suggest otherwise) the default being hidden was preferable, but that's all, looks good :)

web/cobrands/fixmystreet/fixmystreet.js Outdated
@@ -1283,14 +1293,23 @@ $.extend(fixmystreet.set_up, {

reporting_required_phone_email: function() {
var fem = $('#form_email');
var fem_optional = $('#js-optional-email');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good to have this behaviour all here and self contained anyway :)

@neprune neprune requested a review from dracos July 18, 2023 09:19
dracos
dracos requested changes Jul 18, 2023
View reviewed changes
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the one query is all :)

@neprune neprune requested a review from dracos July 18, 2023 09:59
@dracos dracos force-pushed the cbd-jadu-reviewed branch from 76f67b0 to 419e9da Compare July 18, 2023 10:12
dracos
dracos approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo (note as tidying up staging, I force pushed cbd-jadu-reviewed to fix the thing I mentioned due to my review comment, so might need a rebase etc)

@dracos dracos closed this Jul 19, 2023
@dracos dracos force-pushed the cbd-jadu-require-phone branch from db2c993 to 431d991 Compare July 19, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dracos dracos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neprune @dracos