Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return random unprocessed row to daemon. #4545

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Return random unprocessed row to daemon. #4545

merged 2 commits into from
Aug 1, 2023

Conversation

dracos
Copy link
Member

@dracos dracos commented Aug 1, 2023

If there are a number of reports failing to send, leaving it to database order could cause the same reports to be returned over and over, never looking at other waiting reports.

And fix fallback code thing.

@dracos dracos requested a review from davea August 1, 2023 14:39
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #4545 (3224b73) into master (ec6cc12) will increase coverage by 20.48%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 3224b73 differs from pull request most recent head 67c449c. Consider uploading reports for the commit 67c449c to get more accurate results

@@             Coverage Diff             @@
##           master    #4545       +/-   ##
===========================================
+ Coverage   49.03%   69.52%   +20.48%     
===========================================
  Files         353       40      -313     
  Lines       26937     4886    -22051     
  Branches     4149        0     -4149     
===========================================
- Hits        13209     3397     -9812     
+ Misses      12633     1489    -11144     
+ Partials     1095        0     -1095     

see 314 files with indirect coverage changes

Copy link
Member

@davea davea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ 🆗

dracos added 2 commits August 1, 2023 17:17
If there are a number of reports failing to send, leaving it to database
order could cause the same reports to be returned over and over, never
looking at other waiting reports.
It should be `name`, not `code`.
@dracos dracos merged commit e76a09f into master Aug 1, 2023
@dracos dracos temporarily deployed to github-pages August 1, 2023 16:19 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants