Reduce some DB queries #4548
Merged
Reduce some DB queries #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4548 +/- ##
===========================================
- Coverage 82.29% 69.48% -12.82%
===========================================
Files 371 40 -331
Lines 28091 4886 -23205
Branches 4383 0 -4383
===========================================
- Hits 23118 3395 -19723
+ Misses 3658 1491 -2167
+ Partials 1315 0 -1315 |
dracos
force-pushed
the
planned-reduce-db-queries
branch
from
4f3c724 to
5d0b22b
Compare
Store the user_planned_report IDs to use when sorting, and no need to show the shortlisted user on your own shortlist page.
Previously, `translated` would return undef for any Body/Contact row without a translation - this meant any code using this would try and translate any row without a match again one-by-one, even though this check had already been done. By including the fallback column in the translation lookup, it can be returned immediately.
dracos
force-pushed
the
planned-reduce-db-queries
branch
from
5d0b22b to
788062c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worst thing was shortlist report sorting was doing a DB query each call of the sort function (eek).