-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FMS] Add parent categories to dashboard categories view #4700
[FMS] Add parent categories to dashboard categories view #4700
Conversation
I'll need to fix and add tests, but I wanted to check that we were agreed this is what's meant to be achieved |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4700 +/- ##
===========================================
+ Coverage 0 85.47% +85.47%
===========================================
Files 0 340 +340
Lines 0 25022 +25022
Branches 0 4842 +4842
===========================================
+ Hits 0 21388 +21388
- Misses 0 2206 +2206
- Partials 0 1428 +1428 ☔ View full report in Codecov by Sentry. |
Ok, ultimately copied the wards stuff once I understood what was going on - but as far as I see it needs to have the labels selectable in some way (either by click or input check) to select the whole group. Gone in a bit of a long loop on this, so that's actually probably what the real work of this ticket was! |
a0b6ba0
to
59165af
Compare
f068874
to
4d58ca4
Compare
Changes the dropdown for categories in the dashboard stats to be multi-select checkboxes instead of only allowing selecting one category. Adds group labels to group categories in the 'categories' dropdown menu of the dashboard with an all-group-name checkbox to select all of subcategories for that group. Some conversation: https://mysociety.slack.com/archives/C01TK8P1K8T/p1700759729180759 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better, one issue with the template change, and hopeful couple of simplifications :)
82431d6
to
567c396
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one thing more for me checking I've understood it right :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! All seems to work as expected :) I actually just spotted in TfL you also don't need to check the first bit of that condition now as you know it will be an arrayref, but it's fine as is as well.
Sorry to force a re-review but figured I may as well get that done too - but wanted to check I haven't misunderstood and got it wrong either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, yes, that's what I meant - think ->category
is guaranteed to be an arrayref now, which makes things bit neater :)
Switch categories list on dashborad to multi checkbox rather than single option. First step towards: mysociety/societyworks#1458
Add an 'All' subcategories checkbox to select all the categories in one group Arbitrary decision to choose the first parent category from the groups method of a contact. mysociety/societyworks#1458
b986a12
to
5b34f3c
Compare
Add a parent categories column to show if a category is a subcategory.
Arbitrary decision to choose the first parent category from the groups method of a contact.
https://github.com/mysociety/societyworks/issues/1458
[skip changelog]