Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FMS] Allow users to opt out of questionnaires #4758

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

nephila-nacrea
Copy link
Contributor

Closes #1265.

@nephila-nacrea nephila-nacrea self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (824a22d) 85.28% compared to head (1690272) 85.36%.

❗ Current head 1690272 differs from pull request most recent head 6807d24. Consider uploading reports for the commit 6807d24 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4758      +/-   ##
==========================================
+ Coverage   85.28%   85.36%   +0.08%     
==========================================
  Files         339      339              
  Lines       24607    25011     +404     
  Branches     4670     4786     +116     
==========================================
+ Hits        20985    21350     +365     
- Misses       2199     2226      +27     
- Partials     1423     1435      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nephila-nacrea nephila-nacrea requested a review from dracos December 6, 2023 15:54
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the privacy page updates, couple of small things, plus one issue to stop people suddenly getting all their missing questionnaires.

CHANGELOG.md Outdated Show resolved Hide resolved
perllib/FixMyStreet/App/Controller/My.pm Outdated Show resolved Hide resolved
templates/web/base/my/my.html Outdated Show resolved Hide resolved
perllib/FixMyStreet/Script/Questionnaires.pm Outdated Show resolved Hide resolved
@nephila-nacrea nephila-nacrea force-pushed the users-can-opt-out-questionnaires branch from 215c97d to 1690272 Compare December 8, 2023 10:14
@nephila-nacrea nephila-nacrea requested a review from dracos December 8, 2023 10:16
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@nephila-nacrea nephila-nacrea force-pushed the users-can-opt-out-questionnaires branch from 1690272 to 6807d24 Compare December 11, 2023 15:43
@nephila-nacrea nephila-nacrea merged commit 6807d24 into master Dec 11, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specific users to be nominated to never receive questionnaires
2 participants