Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move admin nav to sidebar #5093

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Move admin nav to sidebar #5093

merged 2 commits into from
Aug 29, 2024

Conversation

dracos
Copy link
Member

@dracos dracos commented Aug 2, 2024

Moves the navigation to a sidebar, and makes it prettier

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (c991bc1) to head (3df276e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5093   +/-   ##
=======================================
  Coverage   82.64%   82.65%           
=======================================
  Files         404      404           
  Lines       31526    31526           
  Branches     5000     5000           
=======================================
+ Hits        26055    26057    +2     
+ Misses       3987     3985    -2     
  Partials     1484     1484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos requested a review from davea August 2, 2024 12:47
@dracos dracos removed the request for review from davea August 6, 2024 07:22
@dracos dracos force-pushed the admin-sidebar branch 4 times, most recently from aa9a07f to 53c6085 Compare August 27, 2024 17:37
@dracos dracos requested a review from lucascumsille August 27, 2024 17:43
@lucascumsille
Copy link
Contributor

@dracos I really like it, it looks more tidy and easier to scan.

As a suggestion for the hover effect what do you think if we include a variable for the colour and background, they would have by default $button-primary-text and $button-primary-bg-top. Currently not all the cobrands are overriding those variables, however that is being tackled here, but we stopped working on that PR because we ended just making the change for Surrey, but I could add it to this sprint and finish it.

dracos added 2 commits August 29, 2024 14:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@dracos dracos merged commit 3df276e into master Aug 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants