Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plain text preview links to /_dev/email #5105

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

nephila-nacrea
Copy link
Contributor

@nephila-nacrea nephila-nacrea self-assigned this Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (2460d7d) to head (3067a8e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5105   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         404      404           
  Lines       31462    31466    +4     
  Branches     4988     4988           
=======================================
+ Hits        26008    26012    +4     
  Misses       3975     3975           
  Partials     1479     1479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nephila-nacrea nephila-nacrea force-pushed the plaintext-email-previews branch from 10f299f to 49d2941 Compare August 12, 2024 08:27
@nephila-nacrea nephila-nacrea requested review from neprune and removed request for chrismytton August 12, 2024 08:28
Copy link
Contributor

@neprune neprune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I hadn't even realised it already existed as a query string parameter. LGTM!

@nephila-nacrea nephila-nacrea force-pushed the plaintext-email-previews branch from 49d2941 to 3067a8e Compare August 15, 2024 16:16
@nephila-nacrea nephila-nacrea merged commit 3067a8e into master Aug 15, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants