Dupe suggestions can be disabled on a per-category basis in config #5162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davea
force-pushed
the
surrey-cobrand-category-disable-dupe-suggestions
branch
from
d50a490 to
7fc9801
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## surrey-cobrand #5162 +/- ##
==================================================
- Coverage 82.55% 82.29% -0.27%
==================================================
Files 408 408
Lines 31918 31920 +2
Branches 5090 5091 +1
==================================================
- Hits 26349 26267 -82
- Misses 4076 4164 +88
+ Partials 1493 1489 -4 ☔ View full report in Codecov by Sentry. |
dracos
approved these changes
Sep 13, 2024
| @@ -727,38 +727,42 @@ sub _nearby_json :Private { | |||
| # This is for the list template, this is a list on that page. | |||
| $c->stash->{page} = 'report'; | |||
|
|
|||
| my $dist = $self->_find_distance($c, $params); | |||
| $params->{distance} = $dist / 1000 unless $params->{distance}; # DB measures in km | |||
| if (my $dist = $self->_find_distance($c, $params)) { # distance of 0 means we can skip lookup entirely | |||
There was a problem hiding this comment.
Is fine, but could be done as an early return if not present, then don't need to indent everything further
Setting a `suggestions` value to 0 within the nearby_distances cobrand
feature disables the dupe suggestion feature for that group/category, eg:
COBRAND_FEATURES:
nearby_distances:
my_cobrand:
suggestions:
_fallback: 100
Potholes: 0
davea
force-pushed
the
surrey-cobrand-category-disable-dupe-suggestions
branch
from
7fc9801 to
e6931e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a
suggestionsvalue to 0 within thenearby_distancescobrand feature disables the dupe suggestion feature for that group/category, eg: