Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow through a 0 extra question value. #5245

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

dracos
Copy link
Member

@dracos dracos commented Nov 8, 2024

If an extra question had 0 as a key, it was considered false and not given.

@dracos dracos requested a review from chrismytton November 8, 2024 09:11
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (a020eb8) to head (b4e02cb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5245   +/-   ##
=======================================
  Coverage   82.38%   82.39%           
=======================================
  Files         409      409           
  Lines       32075    32075           
  Branches     5119     5119           
=======================================
+ Hits        26425    26428    +3     
+ Misses       4128     4126    -2     
+ Partials     1522     1521    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

If an extra question had 0 as a key, it
was considered false and not given.
@dracos dracos force-pushed the allow-through-0-extra-question-value branch from 8494a80 to b4e02cb Compare November 9, 2024 07:57
@dracos dracos merged commit b4e02cb into master Nov 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants