-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BUG#29913991: HEARTBEAT EVENT CAN ONLY ADDRESS 32 BIT FILE OFFSET
Problem: When source sends a heartbeat event to replicas, the content of the heartbeat is the source's current positions (log file name and position). The log file name has its own field in the event, but the position is sent as the event log_pos (a 32 bits field). When the source sends a heartbeat event while above 4GB offset of a large binary log file, the log_pos of the event will overflow and will not match the coordinates that the replica knows about. This causes the replica's receiver thread to stop with an error. Solution: To fix this we have created a new flag and an event(HEARTBEAT_EVENT_V2), when this flag is set the source will generate the V2 of heartbeat_event. The new heartbeat_event will have the log_pos field type as uint64, so that it will be able to hold the values greater than 4 gb without any issues. ReviewBoard: 26931
- Loading branch information
Neha Kumari
committed
Nov 19, 2021
1 parent
b490ff4
commit 59e5907
Showing
19 changed files
with
795 additions
and
165 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.