Skip to content

Commit

Permalink
[Breaking] Make commodore family targets infinitely loop on exit
Browse files Browse the repository at this point in the history
We currently take advantage of the BASIC ZP area, but commodore family
targets can only load programs from a BASIC environment. This makes it
intrinsically unsafe to exit by return, since it always returns to a
possibly-clobbered environment.

Instead, exiting by looping still allows a screen's worth of output to
be viewed, without possibly returning to a broken BASIC interpreter.
This is arguably a bugfix, but it's also a very significant change in
behavior, so I'm considering it a breaking change.

We should also have an optional library that saves and restores BASIC ZP
on entry-exit and exits via returning, but that shouldn't block this
change.
  • Loading branch information
mysterymath committed Jun 25, 2024
1 parent 63e13de commit 10d2a5b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mos-platform/commodore/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ add_platform_library(commodore-crt0)
merge_libraries(commodore-crt0
common-copy-zp-data
common-zero-bss
common-exit-return
common-exit-loop
)

add_platform_library(commodore-c
Expand Down

0 comments on commit 10d2a5b

Please sign in to comment.