Skip to content

Commit

Permalink
Remove AsRef<str> generated impl for enums
Browse files Browse the repository at this point in the history
  • Loading branch information
mzeitlin11 committed Jan 5, 2024
1 parent 8157122 commit c3e3c8f
Show file tree
Hide file tree
Showing 395 changed files with 1 addition and 6,872 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ they stay up to date, preventing errors error deserialization errors like (https
does not include the status code.
- The `id` method on `Expandable<T>` now returns a reference: `&T::Id`. All id types implement `Clone` so
to achieve the previous behavior, use `.id().clone()`.
- Removed the `AsRef<str>` implementation for enums, use `as_str` instead.

Since most of these changes are related to code generation, it is likely there are some
breaking changes we missed here. If so, please open an issue (especially for changes that degrade library ergonomics).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,6 @@ impl std::str::FromStr for CreateBillingPortalConfigurationFeaturesCustomerUpdat
}
}
}
impl AsRef<str> for CreateBillingPortalConfigurationFeaturesCustomerUpdateAllowedUpdates {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for CreateBillingPortalConfigurationFeaturesCustomerUpdateAllowedUpdates {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down Expand Up @@ -315,13 +310,6 @@ impl std::str::FromStr
}
}
}
impl AsRef<str>
for CreateBillingPortalConfigurationFeaturesSubscriptionCancelCancellationReasonOptions
{
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display
for CreateBillingPortalConfigurationFeaturesSubscriptionCancelCancellationReasonOptions
{
Expand Down Expand Up @@ -374,11 +362,6 @@ impl std::str::FromStr for CreateBillingPortalConfigurationFeaturesSubscriptionC
}
}
}
impl AsRef<str> for CreateBillingPortalConfigurationFeaturesSubscriptionCancelMode {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for CreateBillingPortalConfigurationFeaturesSubscriptionCancelMode {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down Expand Up @@ -432,11 +415,6 @@ impl std::str::FromStr
}
}
}
impl AsRef<str> for CreateBillingPortalConfigurationFeaturesSubscriptionCancelProrationBehavior {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display
for CreateBillingPortalConfigurationFeaturesSubscriptionCancelProrationBehavior
{
Expand Down Expand Up @@ -519,13 +497,6 @@ impl std::str::FromStr
}
}
}
impl AsRef<str>
for CreateBillingPortalConfigurationFeaturesSubscriptionUpdateDefaultAllowedUpdates
{
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display
for CreateBillingPortalConfigurationFeaturesSubscriptionUpdateDefaultAllowedUpdates
{
Expand Down Expand Up @@ -584,11 +555,6 @@ impl std::str::FromStr
}
}
}
impl AsRef<str> for CreateBillingPortalConfigurationFeaturesSubscriptionUpdateProrationBehavior {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display
for CreateBillingPortalConfigurationFeaturesSubscriptionUpdateProrationBehavior
{
Expand Down Expand Up @@ -769,11 +735,6 @@ impl std::str::FromStr for UpdateBillingPortalConfigurationFeaturesCustomerUpdat
}
}
}
impl AsRef<str> for UpdateBillingPortalConfigurationFeaturesCustomerUpdateAllowedUpdates {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for UpdateBillingPortalConfigurationFeaturesCustomerUpdateAllowedUpdates {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down Expand Up @@ -903,13 +864,6 @@ impl std::str::FromStr
}
}
}
impl AsRef<str>
for UpdateBillingPortalConfigurationFeaturesSubscriptionCancelCancellationReasonOptions
{
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display
for UpdateBillingPortalConfigurationFeaturesSubscriptionCancelCancellationReasonOptions
{
Expand Down Expand Up @@ -962,11 +916,6 @@ impl std::str::FromStr for UpdateBillingPortalConfigurationFeaturesSubscriptionC
}
}
}
impl AsRef<str> for UpdateBillingPortalConfigurationFeaturesSubscriptionCancelMode {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for UpdateBillingPortalConfigurationFeaturesSubscriptionCancelMode {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down Expand Up @@ -1020,11 +969,6 @@ impl std::str::FromStr
}
}
}
impl AsRef<str> for UpdateBillingPortalConfigurationFeaturesSubscriptionCancelProrationBehavior {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display
for UpdateBillingPortalConfigurationFeaturesSubscriptionCancelProrationBehavior
{
Expand Down Expand Up @@ -1107,13 +1051,6 @@ impl std::str::FromStr
}
}
}
impl AsRef<str>
for UpdateBillingPortalConfigurationFeaturesSubscriptionUpdateDefaultAllowedUpdates
{
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display
for UpdateBillingPortalConfigurationFeaturesSubscriptionUpdateDefaultAllowedUpdates
{
Expand Down Expand Up @@ -1172,11 +1109,6 @@ impl std::str::FromStr
}
}
}
impl AsRef<str> for UpdateBillingPortalConfigurationFeaturesSubscriptionUpdateProrationBehavior {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display
for UpdateBillingPortalConfigurationFeaturesSubscriptionUpdateProrationBehavior
{
Expand Down
15 changes: 0 additions & 15 deletions generated/stripe_billing/src/billing_portal_session/requests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,6 @@ impl std::str::FromStr for CreateBillingPortalSessionFlowDataAfterCompletionType
}
}
}
impl AsRef<str> for CreateBillingPortalSessionFlowDataAfterCompletionType {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for CreateBillingPortalSessionFlowDataAfterCompletionType {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down Expand Up @@ -234,11 +229,6 @@ impl std::str::FromStr for CreateBillingPortalSessionFlowDataSubscriptionCancelR
}
}
}
impl AsRef<str> for CreateBillingPortalSessionFlowDataSubscriptionCancelRetentionType {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for CreateBillingPortalSessionFlowDataSubscriptionCancelRetentionType {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down Expand Up @@ -359,11 +349,6 @@ impl std::str::FromStr for CreateBillingPortalSessionFlowDataType {
}
}
}
impl AsRef<str> for CreateBillingPortalSessionFlowDataType {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for CreateBillingPortalSessionFlowDataType {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down
5 changes: 0 additions & 5 deletions generated/stripe_billing/src/billing_portal_session/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,6 @@ impl std::str::FromStr for BillingPortalSessionLocale {
}
}
}
impl AsRef<str> for BillingPortalSessionLocale {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for BillingPortalSessionLocale {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down
15 changes: 0 additions & 15 deletions generated/stripe_billing/src/credit_note/requests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,6 @@ impl std::str::FromStr for CreateCreditNoteLinesType {
}
}
}
impl AsRef<str> for CreateCreditNoteLinesType {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for CreateCreditNoteLinesType {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down Expand Up @@ -331,11 +326,6 @@ impl std::str::FromStr for PreviewCreditNoteLinesType {
}
}
}
impl AsRef<str> for PreviewCreditNoteLinesType {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for PreviewCreditNoteLinesType {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down Expand Up @@ -637,11 +627,6 @@ impl std::str::FromStr for PreviewLinesCreditNoteLinesType {
}
}
}
impl AsRef<str> for PreviewLinesCreditNoteLinesType {
fn as_ref(&self) -> &str {
self.as_str()
}
}
impl std::fmt::Display for PreviewLinesCreditNoteLinesType {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
f.write_str(self.as_str())
Expand Down
Loading

0 comments on commit c3e3c8f

Please sign in to comment.