Feature histogram #1959
Merged
Feature histogram #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the code to contain choice of dataTypes for a feature list.
SteffenHeu
reviewed
Jul 18, 2024
...a/io/github/mzmine/modules/visualization/feat_histogram/FeatureHistogramDatasetProvider.java
Outdated
Show resolved
Hide resolved
...va/io/github/mzmine/modules/visualization/feat_histogram/FeatureHistogramPlotController.java
Outdated
Show resolved
Hide resolved
...va/io/github/mzmine/modules/visualization/feat_histogram/FeatureHistogramPlotController.java
Outdated
Show resolved
Hide resolved
| public Region build() { | ||
| final HistogramPanel histo = new HistogramPanel(); | ||
| final BorderPane mainPane = new BorderPane(histo); | ||
| mainPane.setTop(createDataTypeBox()); |
There was a problem hiding this comment.
usually we put the controls below the plot, e.g. spectra plot, overview, stats...
There was a problem hiding this comment.
Issue is that at the bottom we have a lot of controls already for the histogram itself. So I thought here its better to have the data selection on the top. Maybe we could rethink this when making the HistogramChart itself MVC.
I think I kind of like the data selection, preprocessing parameters on the top and the other controls on the bottom or on the right, but this may depend case to case.
Here is another example of data selection and parameters on the top:
...a/io/github/mzmine/modules/visualization/feat_histogram/FeatureHistogramDatasetProvider.java
Outdated
Show resolved
Hide resolved
|
@SteffenHeu ready from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalization of #1896