Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Ensure store write operations are atomic #93

Closed
rklaehn opened this issue Nov 2, 2022 · 1 comment
Closed

Ensure store write operations are atomic #93

rklaehn opened this issue Nov 2, 2022 · 1 comment
Assignees
@rklaehn
Labels
bug Something isn't working

Comments

@rklaehn
Copy link
Contributor

rklaehn commented Nov 2, 2022

Currently, store write operations are not atomic. Concurrent calls to ensure_id_many can lead to duplicate ids for a cid.

This needs to be fixed, and WriteBatches are not enough. We need transactions.

We need to figure out what rocksdb transaction type to use.
@rklaehn rklaehn added the bug Something isn't working label Nov 2, 2022
@rklaehn rklaehn self-assigned this Nov 2, 2022
@rklaehn rklaehn mentioned this issue Feb 17, 2023
Closed
@ramfox ramfox mentioned this issue Nov 2, 2022
Closed
@b5
Copy link
Member

b5 commented Nov 18, 2022

@rklaehn is this closable? Feels like it has a lot of overlap with #93

@rklaehn rklaehn closed this as completed Nov 21, 2022
@dignifiedquire dignifiedquire transferred this issue from n0-computer/iroh Feb 17, 2023
@ramfox ramfox removed this from iroh Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rklaehn rklaehn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rklaehn @b5