-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: iroh-one #212
feat: iroh-one #212
Conversation
fef3416
to
1bf759c
Compare
iroh-one/src/config.rs
Outdated
} | ||
|
||
// synchronize the rpc config across subsystems | ||
pub fn sync_rpc_client(&mut self) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what exactly is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a convenience function to copy the top level rpc_client
configuration (with the mem addresses) across the sub configs.
@fabricedesre just to clarify some of the stuff here. I don't think we can take on the If that is the case I think the best way to support this is by having |
@Arqu I can actually use cli arguments in my case (it's not regular android either), but I dislike having a mix of configuration through cli args and in a config file. If I can use |
Oh that's really nice to hear! I'll test it out today/tomorrow and report back, should be already set up or pretty close to it. |
@fabricedesre confirming that Sample toml config
Remember to build with If this is ok with you I'd like to move towards merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks!
Based off of the awesome work @fabricedesre did on #188
Took it a little bit further in terms of making it mergeable for us and reducing the maintenance burden of the crate.
@fabricedesre Hope this is a nice middle ground that works for all.
ContentLoader
as @dignifiedquire suggested(actually need to finish this - done)LMK what y'all think