Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow builds without metrics #193

Closed
wants to merge 5 commits into from
Closed

Conversation

Arqu
Copy link
Collaborator

@Arqu Arqu commented Aug 16, 2022

@Arqu Arqu added the fix Fixes a bug label Aug 16, 2022
@Arqu Arqu added this to the DeltaChat milestone Aug 16, 2022
@Arqu Arqu requested a review from dignifiedquire August 16, 2022 07:58
@Arqu Arqu self-assigned this Aug 16, 2022
@dignifiedquire
Copy link
Contributor

hmm, this is a lot of code 😥

@Arqu
Copy link
Collaborator Author

Arqu commented Aug 17, 2022

hmm, this is a lot of code 😥

It is, got any better ideas?

My alternative is to make a null metrics implementation and switch on that with features. Might or might not be better but should be more contained.

@dignifiedquire
Copy link
Contributor

My alternative is to make a null metrics implementation and switch on that with features.

I think that might be nicer, I am worried about things like the resolver code having cfgs all over the place.

@Arqu
Copy link
Collaborator Author

Arqu commented Aug 17, 2022

My alternative is to make a null metrics implementation and switch on that with features.

I think that might be nicer, I am worried about things like the resolver code having cfgs all over the place.

Yeah it's not pretty. And a bit tedious to annotate every call to every metrics call ever. I'll do another branch for it and see where that goes.

@Arqu
Copy link
Collaborator Author

Arqu commented Aug 31, 2022

Closing in favor of #212

@Arqu Arqu closed this Aug 31, 2022
@Arqu Arqu deleted the arqu/compile_no_metrics branch August 31, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

metrics: ability to compile without metrics
2 participants