fix: windows symlink support #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramfox
force-pushed
the
ramfox/symlink_windows_fix
branch
4 times, most recently
from
cb8e297 to
0105466
Compare
ramfox
force-pushed
the
ramfox/symlink_windows_fix
branch
2 times, most recently
from
c92dab7 to
097987c
Compare
ramfox
force-pushed
the
ramfox/symlink_windows_fix
branch
2 times, most recently
from
885574d to
8144e4e
Compare
rklaehn
force-pushed
the
ramfox/symlink_windows_fix
branch
6 times, most recently
from
3fa5991 to
808e2b1
Compare
cargo clippy --target=x86_64-pc-windows-gnu
also clippy windows for iroh-localops
...so we don't have to make the imports conditional to please clippy
rklaehn
force-pushed
the
ramfox/symlink_windows_fix
branch
from
df9ec98 to
fad5242
Compare
b5
reviewed
Oct 24, 2022
|
|
||
| [target.x86_64-pc-windows-gnu] | ||
| linker = "x86_64-w64-mingw32-gcc" |
There was a problem hiding this comment.
This is so you can cross compile for windows on mac and I don't have to go looking for a windows box.
|
CI is giving us headaches. This is clearly moving the ball forward on windows. I'm going to merge without waiting for it to finish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.