feat: Refactor unixfs #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppodolsky
force-pushed
the
feature/unixfs
branch
5 times, most recently
from
d79bda0 to
bc7f4cd
Compare
ppodolsky
force-pushed
the
feature/unixfs
branch
6 times, most recently
from
c755db2 to
92f96a4
Compare
ppodolsky
force-pushed
the
feature/unixfs
branch
from
92f96a4 to
851820b
Compare
Arqu
approved these changes
Dec 19, 2022
| @@ -103,11 +103,14 @@ pub fn parse_range_header(range: &HeaderValue) -> Option<Range<u64>> { | |||
| if start >= end || end == 0 { | |||
| return None; | |||
| } | |||
| Some(Range { start, end }) | |||
| Some(Range { | |||
There was a problem hiding this comment.
Ugh, this is a rough bug on my end.
| ResponseClip::Clip(bytes_reader.bytes.len()), | ||
| &bytes_reader.bytes, | ||
| Some(bytes_reader.bytes.len()), | ||
| &bytes_reader.bytes[pos_current..], |
ppodolsky
added a commit
to izihawa/iroh
that referenced
this pull request
Dec 20, 2022
* feat: Refactor unixfs * pr: fixes * fix: Document fix and correct default for absent gateway path * feat: Skip blocks on seeking
ppodolsky
added a commit
to izihawa/iroh
that referenced
this pull request
Dec 28, 2022
* feat: Refactor unixfs * pr: fixes * fix: Document fix and correct default for absent gateway path * feat: Skip blocks on seeking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseCliphas been deleted but it is better to discuss. I did it because its semantics was not obvious, it was used for clipping both entire response and partial responses fromNodewith non-trivial transitions between them.Worth to note, now
Rangeheader with valuestart-endtranslates to rust structRangewith valuesstartandend + 1.Rangein rust non-inclusive for right bound, it is more convinient.