[WIP] feat: compress blobs on transfer #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
feat-compression
branch
from
1b94353 to
d826dda
Compare
|
Looks like our usage is simply not possible currently: Nullus157/async-compression#141 |
|
you could write a custom inner writer that doesn't pass through the closing... |
we want to call shutdown to get the compressor to finish, but we don't want to call shutdown on the underlying writer. So...
|
Can somebody enlighten me why we want to compress individual files instead of the entire stream? |
|
If we do this we should do the version where the entire request is compressed as one, seee #864 |
|
meh, closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently broken, likely due to a bug somewhere in the asnycread/write impls of async-compression or abao
Closes #739