Fix pre commit failing on modified ts code #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Github Actions introduced `workflow_run` triggere it is no longer needed to cancel pull request runs from forks via scheduled runs. Several `cancelModes` were introduced in order to handle all cases where canceling runs is desired. Documentation has been improved showing all cases and examples how you should implement your own workflow in those cases.
Fix example
Previously the release step was adding the generated dist files to git automatically, which was not a good idea because pre-commit did not fail in case someone modified the .ts file Now the pre-commit check for npm will behave like all other pre-commit checks - if a file will be modified by the check, the file will not be added and pre-commit check will fail allowing the author to add the file manually.
|
Yep. It failed as expected and now it should succeed :) |
|
Wrong repo :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.