Shape Component #90

InfiniteLee · 2018-04-06T00:02:05Z

Add a shape component that when attached to an entity (or child entity) using a body with shape: none updates the shapes on the CANNON.Body. This enables an easy way to define a body made of multiple primitive shapes, which should be a performant alternative to using convex hulls.

The updating of the body is delayed until tick so that if multiple shape components are defined, the body is only updated once. Does not currently support removing of shapes.

Also updated the wireframe code in body to handle shape offsets and orientations correctly, as well as multiple shapes per body.

…oundShapes" (json blob defining attributes of primitive shapes), that creates a body with those primitives as shapes. Also, update the wireframe code to support this, and fix it to correctly display offsets.

If `type === none` in `body` component, body initialization will be delayed until a `shape` component is added. currently shapes can be added but not removed. debug wireframe updates accordingly.

wmurphyrd · 2018-04-06T23:41:23Z

+1 for this idea
I frequently need a shape different from what three2cannon will produce (e.g. a box that doesn't expand to include child entities or a box that is just a little thicker than the plane geometry it encloses for easier grabbing), and the current process involves writing a custom component each time to listen for the body loaded event and create the shapes

donmccurdy

Great addition, thanks! 🙂

donmccurdy · 2018-04-07T20:23:49Z

src/components/body/body.js

+    }
+  },
+
+  addShape(shapeData) {


not using ES6 syntax here yet, so this must be:

addShape: function (shapeData) {

donmccurdy · 2018-04-07T20:25:55Z

src/components/body/body.js

+    }
+
+    var type = shapeData.shape;
+    var scale = this.el.object3D.scale;


Let's get world-space scale:

var scale = new THREE.Vector3(); this.el.object3D.getWorldScale( scale );

donmccurdy · 2018-04-07T20:29:34Z

src/components/body/body.js

+          orientation.y,
+          orientation.z,
+          orientation.w
+        );


I think wireframe.quaternion.copy(orientation) should work here, right? unless there was some hitch between the cannonjs and threejs quaternion...

donmccurdy · 2018-04-07T20:30:29Z

src/components/body/body.js

+      }
+
+      if (orientation) {
+        orientation.inverse(orientation);


This is a reference to a quaternion still in body.shapeOrientations, so I think we want to make a copy before inverting.

will add .clone() where orientation is set.

orientation = this.body.shapeOrientations[i].clone(),

oh nevermind that's a threejs method, not a cannonjs one.

donmccurdy · 2018-04-07T20:32:05Z

src/components/shape/shape.js

+    radiusTop: {type: 'number', default: 1},
+    radiusBottom: {type: 'number', default: 1},
+    height: {type: 'number', default: 1},
+    numSegments: {type: 'int', default: 8}


let's prefix these properties:

sphereRadius boxHalfExtents cylinderRadiusTop ...

I would prefer not to- I really like that this exactly matches what those properties are called in threejs. (Selfishly I am also writing some tooling upstream of this that I don't want to have to constantly try to remember what the properties are supposed to be called). I would argue that if we want to be more explicit, we should add the other shape components back in (sphere-shape, box-shape, cylinder-shape)

What about adding a updateSchema handler a la geometry that makes the right properties available for the selected shape? That may provide the same clarity of purpose as prefixing

Ok, I'm fine with keeping the names then. But even easier than updateSchema, we can do this:

radiusTop: { type: 'number', default: 1, if: {shape: ['cylinder']} } ...

donmccurdy · 2018-04-07T20:33:42Z

src/components/shape/shape.js

+      return 'dynamic-body';
+    } else if (el.components.hasOwnProperty('static-body')) {
+      return'static-body';
+    }


Would do el.hasAttribute('foo-body') here instead

donmccurdy · 2018-04-07T20:34:44Z

src/components/shape/shape.js

+      this.bodyEl = this.bodyEl.parentNode;
+      type = this._findType(this.bodyEl);
+    }
+    this.bodyEl.components[type].addShape(this.data);


What do you think about having the shape component construct a CANNON.Shape instance and pass that into components.body.addShape( shape )`?

i have to think about that one- I vaguely recall I had a reason not to do that, but that might not be the case anymore.

Ok, feels cleaner IMO but if there's some issue we can leave it alone for now.

donmccurdy · 2018-04-07T20:35:16Z

src/components/shape/shape.js

+  remove: function() {
+    if (this.bodyEl.parentNode) {
+      console.warn('removing shape component not currently supported');
+    }


Is there a case where remove could be called but no parent node exists?

If the parent is removed first we don't need to warn about the shape being removed.

…e rotation of cylinder shapes similar to how mesh2shape does it (rotate by 90 degrees). Fix various bugs.

donmccurdy · 2018-04-11T04:40:17Z

Nice work, thanks! Will test this out a bit and then cut a new release.

donmccurdy · 2018-04-15T01:06:10Z

Published 3.1.0. 🎊

jewingo · 2019-02-27T18:19:11Z

It looks like compound colliders break when an orientation property is specified (3.3.0) for any component shape; an alternative is using the constraint functionality to create a complex physics body (rotation seems to work fine for primitive body shapes) but I'm worried about overhead with this methodology. Looking into using wmurphyrd's aframe-physics-extras for this

InfiniteLee added 7 commits March 30, 2018 18:10

Add a new shape "compound". Requires specification of 1 or more "comp…

790d5a3

…oundShapes" (json blob defining attributes of primitive shapes), that creates a body with those primitives as shapes. Also, update the wireframe code to support this, and fix it to correctly display offsets.

Added shape components.

f66ef26

If `type === none` in `body` component, body initialization will be delayed until a `shape` component is added. currently shapes can be added but not removed. debug wireframe updates accordingly.

eof newline

fec4fda

don't call this._pause() when this.shouldUpdateBody

c8add50

remove *-shape helper components

da2908d

cleanup

ee9ff27

update default 'numSegments' to match three.js'

28819b8

donmccurdy reviewed Apr 7, 2018

View reviewed changes

InfiniteLee and others added 3 commits April 7, 2018 20:05

some fixes/cleanup from review

a4a3776

can't do clone() on a cannonjs quaternion

5a12e10

move the creation of the shape object into the shape component. Handl…

be3e43f

…e rotation of cylinder shapes similar to how mesh2shape does it (rotate by 90 degrees). Fix various bugs.

InfiniteLee mentioned this pull request Apr 10, 2018

Feature/inflatable rigid bodies Hubs-Foundation/hubs#176

Merged

donmccurdy merged commit a83cb42 into n5ro:master Apr 11, 2018

This was referenced Apr 11, 2018

Support Cannon compound shapes #53

Closed

Move wireframe logic into a separate helper #52

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shape Component #90

Shape Component #90

InfiniteLee commented Apr 6, 2018

wmurphyrd commented Apr 6, 2018

donmccurdy left a comment

donmccurdy Apr 7, 2018

donmccurdy Apr 7, 2018

donmccurdy Apr 7, 2018

donmccurdy Apr 7, 2018

InfiniteLee Apr 8, 2018

InfiniteLee Apr 8, 2018

donmccurdy Apr 7, 2018

InfiniteLee Apr 8, 2018

wmurphyrd Apr 8, 2018

donmccurdy Apr 9, 2018

donmccurdy Apr 7, 2018

donmccurdy Apr 7, 2018

InfiniteLee Apr 8, 2018

donmccurdy Apr 9, 2018

donmccurdy Apr 7, 2018

InfiniteLee Apr 8, 2018

donmccurdy commented Apr 11, 2018

donmccurdy commented Apr 15, 2018

jewingo commented Feb 27, 2019

Shape Component #90

Shape Component #90

Conversation

InfiniteLee commented Apr 6, 2018

wmurphyrd commented Apr 6, 2018

donmccurdy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

donmccurdy commented Apr 11, 2018

donmccurdy commented Apr 15, 2018

jewingo commented Feb 27, 2019