Document Vehicles #641
Merged
Document Vehicles #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaMech
requested changes
Jun 21, 2024
MegaMech
requested changes
Jun 22, 2024
MegaMech
requested changes
Jun 24, 2024
src/code_80005FD0.c
Outdated
| position[0] = var_f2; | ||
| position[1] = var_f12; | ||
| position[2] = var_f14; | ||
| return get_angle_path(sp50, position); |
There was a problem hiding this comment.
sp50 good name might be pos or oldPos
get_angle_path if it returns the angle between sp50 and position. get_angle
get_angle_path is essentially get_angle_between_two_vectors_dup.
Perhaps get_angle_between_two_vectors_vehicles?
There was a problem hiding this comment.
yeah get_angle_path is a kind of duplicate of get_angle_between_two_vectors_dup
MegaMech
requested changes
Jun 27, 2024
MegaMech
requested changes
Jun 27, 2024
| smokePos[1] = (f32) ((f64) gTrainList[i].locomotive.position[1] + 65.0); | ||
| smokePos[2] = (f32) ((f64) gTrainList[i].locomotive.position[2] + 25.0); | ||
| move_to_point_direction(smokePos, gTrainList[i].locomotive.position, orientationYUpdate); | ||
| spawn_train_smoke(i, smokePos, 1.1f); |
There was a problem hiding this comment.
Can you make a define for 1.1f it's the smoke heighth.
src/code_80005FD0.c
Outdated
| D_80163318[payerId] = trackSegment; | ||
| D_80162FCE = func_8000C0BC(posX, posY, posZ, trackSegment, &pathIndex); | ||
| D_80162FCE = find_closest_waypoint_track_segment(posX, posY, posZ, trackSegment, &pathIndex); |
There was a problem hiding this comment.
Not sure I like the _track_segment part.
Should use trackSection instead of trackSegment I think.
MegaMech
previously approved these changes
Aug 23, 2024
src/code_80005FD0.c
Outdated
| @@ -4890,15 +4894,15 @@ void func_80013854(Player *player) { | |||
| } | |||
| } | |||
|
|
|||
| void func_800139E4(f32 arg0, f32 arg1, s32 arg2, s32 arg3, VehicleStuff *vehicle, TrackWaypoint *waypointList) { | |||
| void initialize_toad_turnpike_vehicle(f32 speedA, f32 speedB, s32 numVehicles, s32 arg3, VehicleStuff *vehicleList, TrackWaypoint *waypointList) { | |||
MegaMech
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.