Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libultra asm #648

Merged
merged 3 commits into from
Aug 23, 2024
Merged

update libultra asm #648

merged 3 commits into from
Aug 23, 2024

Conversation

coco875
Copy link
Contributor

@coco875 coco875 commented Jul 10, 2024

use https://github.com/n64decomp/libreultra to update asm of libultra

Copy link
Collaborator

@MegaMech MegaMech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is the thread tail parts where I don't think it will shift properly on gcc.

@@ -33,7 +33,7 @@ $(eval $(call validate-option,COMPILER,ido gcc))
DEBUG ?= 0

# Compile with GCC
GCC ?= 0
GCC ?= 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh forget to set again to 0

@MegaMech MegaMech merged commit 7025ff0 into n64decomp:master Aug 23, 2024
1 of 3 checks passed
@coco875 coco875 deleted the update-asm branch September 1, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants