Doc code 80005fd0 #697

coco875 · 2025-01-02T01:17:11Z

No description provided.

coco875 · 2025-01-02T01:17:51Z

I will rename file once 684 are merge

coco875 · 2025-01-02T01:20:21Z

MegaMech · 2025-01-03T18:48:09Z

asm/non_matchings/code_80005FD0/func_800088D8.s

@@ -69,14 +69,14 @@ glabel func_800088D8
 /* 0095D0 800089D0 03193821 */   addu  $a3, $t8, $t9
 /* 0095D4 800089D4 3C0E800E */  lui   $t6, %hi(gDemoMode)
 /* 0095D8 800089D8 95CEC51C */  lhu   $t6, %lo(gDemoMode)($t6)
-/* 0095DC 800089DC 3C048016 */  lui   $a0, %hi(D_80164450) # $a0, 0x8016
-/* 0095E0 800089E0 24844450 */  addiu $a0, %lo(D_80164450) # addiu $a0, $a0, 0x4450
+/* 0095DC 800089DC 3C048016 */  lui   $a0, %hi(gLapProgressScore) # $a0, 0x8016


What is gLapProgressScore? The confusing part is score

Players don't really get scored on the progress in the course. I would imagine that gLapProgress would track which waypoint you're on in the course. But we already have this variable gNearestWaypoint or whatever.

This appears to be numPathPointsTraversed?

MegaMech · 2025-01-03T18:49:36Z

asm/non_matchings/code_80005FD0/func_800088D8.s

-/* 0096E8 80008AE8 3C0B8016 */  lui   $t3, %hi(D_80163478) # $t3, 0x8016
-/* 0096EC 80008AEC 856B3478 */  lh    $t3, %lo(D_80163478)($t3)
+/* 0096E8 80008AE8 3C0B8016 */  lui   $t3, %hi(gPlayerInFront) # $t3, 0x8016
+/* 0096EC 80008AEC 856B3478 */  lh    $t3, %lo(gPlayerInFront)($t3)


Does this mean 'player in 1st place' or 'a player in front of another player'

If it's in 1st place. We need a name morel ike gPlayerInFirstPlace

it's say in two player with player have the best rank, so in one player it's always player one but in two player mode it can be player one or player two even if both and in 7th and 8th

gBestRankedPlayer

yes but all player are name player so it's player who can be play only

gBestRankedHumanPlayer ?

MegaMech · 2025-01-03T18:51:30Z

asm/non_matchings/code_80005FD0/func_8000B140.s

@@ -141,24 +141,24 @@ glabel func_8000B140
 /* 00BF2C 8000B32C 3125FFFF */  andi  $a1, $t1, 0xffff
 /* 00BF30 8000B330 00003025 */  move  $a2, $zero
 /* 00BF34 8000B334 24070014 */  li    $a3, 20
-/* 00BF38 8000B338 3C0C8016 */  lui   $t4, %hi(D_80164430) # $t4, 0x8016
+/* 00BF38 8000B338 3C0C8016 */  lui   $t4, %hi(gCurrentWaypointCountByPathIndex) # $t4, 0x8016


gCurrentPathCount?

D_80164430 = gWaypointCountByPathIndex[pathIndex];
We're taking the array of paths. And selecting a path.

gSelectedPathCount?

MegaMech · 2025-01-03T18:57:46Z

asm/non_matchings/code_80005FD0/func_8000B140.s

 /* 00BF58 8000B358 A7A300E4 */  sh    $v1, 0xe4($sp)
 /* 00BF5C 8000B35C AFA800FC */  sw    $t0, 0xfc($sp)
 /* 00BF60 8000B360 A7A900E6 */  sh    $t1, 0xe6($sp)
 /* 00BF64 8000B364 AFAA00F0 */  sw    $t2, 0xf0($sp)
 /* 00BF68 8000B368 E7A000DC */  swc1  $f0, 0xdc($sp)
 /* 00BF6C 8000B36C E7A20060 */  swc1  $f2, 0x60($sp)
-/* 00BF70 8000B370 0C001EFE */  jal   func_80007BF8
+/* 00BF70 8000B370 0C001EFE */  jal   is_waypoint_in_range


is_path_point_in_range

// @return bool If path point is in the range
range_path_point
?

My only thought here, is it would be nice if we found a way to be less verbose kinda like how python does someVar.range()
but whatever.
You can ignore this one if u want.

it's a little more complex then a bool
return

1: waypoint is within normal range

-1: waypoint is within wrapped range

2: waypoint is out of range

0: invalid range parameters

Could you please add that in the comments of the function if you have not already.

I also think we should use path point

asm/non_matchings/code_80005FD0/kart_ai_use_item_strategy.s

MegaMech · 2025-01-04T02:06:55Z

asm/non_matchings/code_80005FD0/kart_ai_use_item_strategy.s

@@ -782,7 +782,7 @@ glabel L8001B6AC
 /* 01C330 8001B730 100001C0 */  b     .L8001BE34
 /* 01C334 8001B734 86020004 */   lh    $v0, 4($s0)
 glabel L8001B738
-/* 01C338 8001B738 0C006AFB */  jal   func_8001ABEC
+/* 01C338 8001B738 0C006AFB */  jal   reset_strategy_if_actor_valid


reset behaviour?

it's reset the item strategy it have no link with behaviour

if_actor_valid should not be included in the function name.

Code validation should typically be expected.

reset_cpu_item_strategy ?

MegaMech · 2025-01-04T02:07:17Z

asm/non_matchings/code_80005FD0/update_player_path_completion.s

 /* 00A1EC 800095EC AFA40050 */   sw    $a0, 0x50($sp)
 /* 00A1F0 800095F0 0C0046B9 */  jal   reset_kart_ai_behaviour
 /* 00A1F4 800095F4 8FA40050 */   lw    $a0, 0x50($sp)
 /* 00A1F8 800095F8 8FA40050 */  lw    $a0, 0x50($sp)
 /* 00A1FC 800095FC 3C0F8016 */  lui   $t7, %hi(D_8016348C) # $t7, 0x8016
 /* 00A200 80009600 85EF348C */  lh    $t7, %lo(D_8016348C)($t7)
-/* 00A204 80009604 3C018016 */  lui   $at, %hi(D_801642D8 + 0x6) # 0x8016
+/* 00A204 80009604 3C018016 */  lui   $at, %hi(gCpuItemStrategy + 0x6) # 0x8016


by memory once I name a variable with CPU in uppercase but you say no so I rename with cpu in pascal case

MegaMech · 2025-01-04T02:08:06Z

asm/non_matchings/code_80005FD0/update_player_path_completion.s

-/* 009F88 80009388 8CC63448 */   lw    $a2, %lo(D_80163448)($a2)
+/* 009F80 80009380 3C068016 */   lui   $a2, %hi(gActualPath) # $a2, 0x8016
+/* 009F84 80009384 0C002E57 */  jal   update_player_position_factor
+/* 009F88 80009388 8CC63448 */   lw    $a2, %lo(gActualPath)($a2)


if actual path refers to the path the AI use. We should make this clear this is like the gMainPath or gCoursePath or gAIPath or something like that.

not sure I think it's a little more general then just AI

This is being set to a path index of a player.

gPlayerPathIndex or something

MegaMech · 2025-01-04T02:09:22Z

asm/non_matchings/code_80091750/func_800AC458.s

-/* 0AD424 800AC824 3C048016 */  lui   $a0, %hi(D_80164478) # $a0, 0x8016
-/* 0AD428 800AC828 24844478 */  addiu $a0, %lo(D_80164478) # addiu $a0, $a0, 0x4478
+/* 0AD424 800AC824 3C048016 */  lui   $a0, %hi(gCharacterPlayer) # $a0, 0x8016
+/* 0AD428 800AC828 24844478 */  addiu $a0, %lo(gCharacterPlayer) # addiu $a0, $a0, 0x4478


gCharacterIdDup ?

src/code_80005FD0.c

MegaMech · 2025-01-15T20:19:31Z

The file name cpu_logic doesn't encompass everything that goes on in this function:

vehicles
camera demo/end of race stuff
cpu logic

Could you try splitting the file? Or is that what this is?

MegaMech · 2025-01-15T20:18:24Z

src/spawn_players.c

@@ -58,7 +58,7 @@ s32 gCountBChangement[8];
 bool gIsPlayerTripleBButtonCombo[8];
 s32 gTimerBoostTripleBCombo[8];

-s16 chooseKartAIPlayers[7];
+s16 chooseCPUPlayers[7];


cpu_chooseCharacters ?

MegaMech · 2025-01-15T20:24:45Z

src/cpu_logic.h

-    /* 0x6 */ s16 laps;  // confirm?
-    /* 0x8 */ s32 blank;
-    /* 0xC */ s32 unkC;
-};


Why is it that this struct is deleted. and yet replaced with CpuItemStrategyData which is 2 struct members bigger?
It makes sense that they might be the same, but it's weird that it matched like that. Sort of

MegaMech · 2025-01-15T20:25:33Z

asm/non_matchings/code_80005FD0/kart_ai_use_item_strategy.s

@@ -782,7 +782,7 @@ glabel L8001B6AC
 /* 01C330 8001B730 100001C0 */  b     .L8001BE34
 /* 01C334 8001B734 86020004 */   lh    $v0, 4($s0)
 glabel L8001B738
-/* 01C338 8001B738 0C006AFB */  jal   func_8001ABEC
+/* 01C338 8001B738 0C006AFB */  jal   reset_strategy_if_actor_valid


reset_cpu_item_strategy ?

coco875 added 10 commits December 20, 2024 16:09

document waypoint and more

5225182

more documentation

0b4b9e6

continue document

5ffe630

even more rename

ac5b39d

document CPU item strategy

1061ac9

more documentation

fb98ecc

continue rename

e2fb028

a little more documentation

f4f2b07

more documentation

cb3fef4

more rename

d9533b8

more rename

e6ac6e0

MegaMech requested changes Jan 4, 2025

View reviewed changes

coco875 added 8 commits January 4, 2025 22:04

Merge remote-tracking branch 'upstream/master' into doc-code_80005FD0

9d875c9

Update menu_items.h

b396059

rename code_80005FD0 to cpu_logic

1f1b2e4

some change

6e6c25a

some rename

a2f904c

change waypoint to path

38e0ddc

Update torch

9f1799a

change gCpu to cpu_

34abc56

MegaMech reviewed Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doc code 80005fd0 #697

Doc code 80005fd0 #697

coco875 commented Jan 2, 2025

coco875 commented Jan 2, 2025 •

edited

Loading

coco875 commented Jan 2, 2025 •

edited

Loading

MegaMech Jan 3, 2025

MegaMech Jan 15, 2025

MegaMech Jan 3, 2025

coco875 Jan 4, 2025

MegaMech Jan 14, 2025

coco875 Jan 14, 2025 •

edited

Loading

MegaMech Jan 15, 2025

MegaMech Jan 3, 2025

MegaMech Jan 3, 2025

coco875 Jan 4, 2025

MegaMech Jan 14, 2025

MegaMech Jan 4, 2025

coco875 Jan 4, 2025

MegaMech Jan 15, 2025

MegaMech Jan 15, 2025 •

edited

Loading

MegaMech Jan 4, 2025

coco875 Jan 4, 2025

MegaMech Jan 4, 2025

coco875 Jan 5, 2025

MegaMech Jan 15, 2025

MegaMech Jan 4, 2025

MegaMech commented Jan 15, 2025 •

edited

Loading

MegaMech Jan 15, 2025

MegaMech Jan 15, 2025

MegaMech Jan 15, 2025 •

edited

Loading

Doc code 80005fd0 #697

Are you sure you want to change the base?

Doc code 80005fd0 #697

Conversation

coco875 commented Jan 2, 2025

coco875 commented Jan 2, 2025 • edited Loading

coco875 commented Jan 2, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coco875 Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MegaMech Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MegaMech commented Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MegaMech Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

coco875 commented Jan 2, 2025 •

edited

Loading

coco875 commented Jan 2, 2025 •

edited

Loading

coco875 Jan 14, 2025 •

edited

Loading

MegaMech Jan 15, 2025 •

edited

Loading

MegaMech commented Jan 15, 2025 •

edited

Loading

MegaMech Jan 15, 2025 •

edited

Loading