Merge pull request #3629 from n8n-io/n8n-3995

Apply `node-param-array-type-assertion`
n8n-io · Jul 1, 2022 · 53f4716 · 53f4716
2 parents 5abc48f + 1fe4294
commit 53f4716
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 18 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -455,6 +455,7 @@ module.exports = {
 				'n8n-nodes-base/node-param-resource-without-no-data-expression': 'error',
 				'n8n-nodes-base/node-param-type-options-missing-from-limit': 'error',
 				'n8n-nodes-base/node-param-description-missing-from-dynamic-multi-options': 'error',
+				'n8n-nodes-base/node-param-array-type-assertion': 'error',
 				'n8n-nodes-base/node-dirname-against-convention': 'error',
 			},
 		},

diff --git a/packages/nodes-base/nodes/BambooHr/v1/actions/employee/create/shareDescription.ts b/packages/nodes-base/nodes/BambooHr/v1/actions/employee/create/shareDescription.ts
@@ -3,7 +3,7 @@ import {
 } from 'n8n-workflow';
 
 export const createEmployeeSharedDescription = (sync = false): INodeProperties[] => {
-	let elements = [
+	let elements: INodeProperties[] = [
 		{
 			displayName: 'Address',
 			name: 'address',
@@ -290,7 +290,7 @@ export const createEmployeeSharedDescription = (sync = false): INodeProperties[]
 			placeholder: '123-45-6789',
 			description: 'A standard United States Social Security number, with dashes',
 		},
-	] as INodeProperties[];
+	];
 
 	if (sync === true) {
 		elements = elements.map(element => {

diff --git a/packages/nodes-base/nodes/BambooHr/v1/actions/employee/update/sharedDescription.ts b/packages/nodes-base/nodes/BambooHr/v1/actions/employee/update/sharedDescription.ts
@@ -3,7 +3,7 @@ import {
 } from 'n8n-workflow';
 
 export const updateEmployeeSharedDescription = (sync = false): INodeProperties[] => {
-	let elements = [
+	let elements: INodeProperties[] = [
 		{
 			displayName: 'Address',
 			name: 'addasasress',
@@ -316,7 +316,7 @@ export const updateEmployeeSharedDescription = (sync = false): INodeProperties[]
 			placeholder: '123-45-6789',
 			description: 'A standard United States Social Security number, with dashes',
 		},
-	] as INodeProperties[];
+	];
 
 	if (sync === true) {
 		elements = elements.map(element => {

diff --git a/packages/nodes-base/nodes/Notion/BlockDescription.ts b/packages/nodes-base/nodes/Notion/BlockDescription.ts
@@ -6,7 +6,7 @@ import {
 	blocks,
 } from './Blocks';
 
-export const blockOperations = [
+export const blockOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -34,7 +34,7 @@ export const blockOperations = [
 		],
 		default: 'append',
 	},
-] as INodeProperties[];
+];
 
 export const blockFields = [
 

diff --git a/packages/nodes-base/nodes/Notion/DatabaseDescription.ts b/packages/nodes-base/nodes/Notion/DatabaseDescription.ts
@@ -2,7 +2,7 @@ import {
 	INodeProperties,
 } from 'n8n-workflow';
 
-export const databaseOperations = [
+export const databaseOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -66,9 +66,9 @@ export const databaseOperations = [
 		],
 		default: 'get',
 	},
-] as INodeProperties[];
+];
 
-export const databaseFields = [
+export const databaseFields: INodeProperties[] = [
 
 	/* -------------------------------------------------------------------------- */
 	/*                                database:get                                */
@@ -301,4 +301,4 @@ export const databaseFields = [
 			},
 		],
 	},
-] as INodeProperties[];
+];
diff --git a/packages/nodes-base/nodes/Notion/DatabasePageDescription.ts b/packages/nodes-base/nodes/Notion/DatabasePageDescription.ts
@@ -16,7 +16,7 @@ import {
 	filters,
 } from './Filters';
 
-export const databasePageOperations = [
+export const databasePageOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -90,7 +90,7 @@ export const databasePageOperations = [
 		],
 		default: 'create',
 	},
-] as INodeProperties[];
+];
 
 export const databasePageFields = [
 

diff --git a/packages/nodes-base/nodes/Notion/PageDescription.ts b/packages/nodes-base/nodes/Notion/PageDescription.ts
@@ -6,7 +6,7 @@ import {
 	blocks,
 } from './Blocks';
 
-export const pageOperations = [
+export const pageOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -75,7 +75,7 @@ export const pageOperations = [
 		],
 		default: 'create',
 	},
-] as INodeProperties[];
+];
 
 export const pageFields = [
 

diff --git a/packages/nodes-base/nodes/Notion/UserDescription.ts b/packages/nodes-base/nodes/Notion/UserDescription.ts
@@ -2,7 +2,7 @@ import {
 	INodeProperties,
 } from 'n8n-workflow';
 
-export const userOperations = [
+export const userOperations: INodeProperties[] = [
 	{
 		displayName: 'Operation',
 		name: 'operation',
@@ -29,9 +29,9 @@ export const userOperations = [
 		],
 		default: 'get',
 	},
-] as INodeProperties[];
+];
 
-export const userFields = [
+export const userFields: INodeProperties[] = [
 
 	/* -------------------------------------------------------------------------- */
 	/*                                user:get                                    */
@@ -97,4 +97,4 @@ export const userFields = [
 		default: 50,
 		description: 'Max number of results to return',
 	},
-] as INodeProperties[];
+];