Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Shopify Node): Update Shopify API version #10155

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jul 23, 2024

Summary

Adds Const.ts to track the version number of the API, This is placed here so we can use it for the credential tests, OAuth and the Trigger node connection. Also adds a notice to the nodes setting so users can see what version of the API the node is using.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1100/shopfy-update-api

@Joffcom Joffcom requested a review from ShireenMissi July 23, 2024 09:19
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jul 23, 2024
@Joffcom
Copy link
Member Author

Joffcom commented Jul 25, 2024

@ShireenMissi this is ready again

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Jul 26, 2024

Passing run #6156 ↗︎

0 387 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: e3e5d3d248
Status: Passed Duration: 04:37 💡
Started: Jul 26, 2024 9:11 AM Ended: Jul 26, 2024 9:15 AM

Review all test suite changes for PR #10155 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit e2ee915 into master Jul 29, 2024
27 checks passed
@Joffcom Joffcom deleted the node-1100-shopfy-update-api branch July 29, 2024 09:05
MiloradFilipovic added a commit that referenced this pull request Jul 30, 2024
* master:
  docs: Update login url for OpenAI node (no-changelog) (#10222)
  fix(LinkedIn Node): Fix issue with some characters cutting off posts early (#10185)
  fix(Google BigQuery Node): Send timeoutMs in query, pagination support (#10205)
  feat(core): Show Public API key value only once (no-changelog) (#10126)
  refactor(core): Display stack trace in error reporter (no-changelog) (#10225)
  fix(core): Fix missing successful items on continueErrorOutput with multiple outputs (#10218)
  fix(n8n Form Trigger Node): Remove custom attribution option (no-changelog) (#10229)
  feat(n8n Form Trigger Node): Improvements (#10092)
  refactor(core): Port path, host, port, listen_address and protocol config (no-changelog) (#10223)
  docs: Update add options text (no-changelog) (#10049)
  fix(Postgres Node): Option to treat query parameters enclosed in single quotas as text (#10214)
  refactor(core): Decouple server started event from internal hooks (no-changelog) (#10221)
  feat(Shopify Node): Update Shopify API version (#10155)
  fix(editor): Defer `User saved credentials` telemetry event for OAuth credentials (#10215)
  fix(editor): Fix parameter input glitch when there was an error loading remote options (#10209)
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants