Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Shopify Node): Update Shopify API version #10155

Merged
merged 8 commits into from
Jul 29, 2024
+10 −5
Merged

feat(Shopify Node): Update Shopify API version #10155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c4b554a
Update versions
Joffcom Jul 12, 2024
152d67a
Merge branch 'master' of github.com:n8n-io/n8n into node-1100-shopfy-…
Joffcom Jul 15, 2024
58291b4
improve notice
Joffcom Jul 15, 2024
9b90d3d
Tweak to support oauth
Joffcom Jul 22, 2024
bbe3ceb
Merge branch 'master' of github.com:n8n-io/n8n into node-1100-shopfy-…
Joffcom Jul 22, 2024
b1ae7a2
update from review
Joffcom Jul 24, 2024
041da4e
Merge branch 'master' of github.com:n8n-io/n8n into node-1100-shopfy-…
Joffcom Jul 24, 2024
e3e5d3d
lint
Joffcom Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/nodes-base/credentials/ShopifyAccessTokenApi.credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import type {
ICredentialType,
INodeProperties,
} from 'n8n-workflow';

export class ShopifyAccessTokenApi implements ICredentialType {
name = 'shopifyAccessTokenApi';

Expand Down Expand Up @@ -51,7 +50,7 @@ export class ShopifyAccessTokenApi implements ICredentialType {

test: ICredentialTestRequest = {
request: {
baseURL: '=https://{{$credentials?.shopSubdomain}}.myshopify.com/admin/api/2019-10',
baseURL: '=https://{{$credentials?.shopSubdomain}}.myshopify.com/admin/api/2024-07',
url: '/products.json',
},
};
Expand Down
3 changes: 1 addition & 2 deletions packages/nodes-base/credentials/ShopifyApi.credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import type {
IHttpRequestOptions,
INodeProperties,
} from 'n8n-workflow';

export class ShopifyApi implements ICredentialType {
name = 'shopifyApi';

Expand Down Expand Up @@ -63,7 +62,7 @@ export class ShopifyApi implements ICredentialType {

test: ICredentialTestRequest = {
request: {
baseURL: '=https://{{$credentials.shopSubdomain}}.myshopify.com/admin/api/2019-10',
baseURL: '=https://{{$credentials.shopSubdomain}}.myshopify.com/admin/api/2024-07',
url: '/products.json',
},
};
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Shopify/GenericFunctions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export async function shopifyApiRequest(
const options: IRequestOptions = {
method,
qs: query,
uri: uri || `https://${credentials.shopSubdomain}.myshopify.com/admin/api/2019-10${resource}`,
uri: uri || `https://${credentials.shopSubdomain}.myshopify.com/admin/api/2024-07/${resource}`,
body,
json: true,
};
Expand Down
7 changes: 7 additions & 0 deletions packages/nodes-base/nodes/Shopify/Shopify.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ export class Shopify implements INodeType {
},
],
properties: [
{
displayName: 'Shopify API Version: 2024-07',
type: 'notice',
name: 'apiVersion',
default: '',
isNodeSetting: true,
},
{
displayName: 'Authentication',
name: 'authentication',
Expand Down
Loading