Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Delete mistakenly commited node file (no-changelog) #10213

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

OlegIvaniv
Copy link
Contributor

Summary

I wrongly committed an extra WIP code for a different node in #10184 this PR removes it.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jul 26, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 26, 2024

Passing run #6163 ↗︎

0 389 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: f790832a38
Status: Passed Duration: 04:06 💡
Started: Jul 26, 2024 1:27 PM Ended: Jul 26, 2024 1:31 PM

Review all test suite changes for PR #10213 ↗︎

@netroy netroy merged commit 6f1d4ad into master Jul 26, 2024
27 checks passed
@netroy netroy deleted the remove_unused_vector_store_node branch July 26, 2024 13:45
MiloradFilipovic added a commit that referenced this pull request Jul 29, 2024
* master:
  feat(HTTP Request Node): Add option to disable lowercase headers (#10154)
  feat: Recovery option for jsonParse helper (#10182)
  fix: Better error message when calling data transformation functions on a null value (#10210)
  refactor: Delete mistakenly commited node file (no-changelog) (#10213)
  refactor(editor): Add Infisical deprecation notice (#10191)
  feat(editor): Show new executions as `Queued` in the UI, until they actually start (#10204)
  refactor: Update Langchain modules & add Ollama tools support (#10208)
  feat(Sentiment Analysis Node): Implement Sentiment Analysis node (#10184)
  fix: Add original error message to messages, do not obfuscate if description provided in options (no-changelog) (#10202)
  fix(Google Sheets Node): Fix Google Sheet URL regex (#10195)
  fix(Google Sheets Node): Add column names row if sheet is empty (#10200)
  fix(Google Sheets Node): Do not insert row_number as a new column, do not checkForSchemaChanges in update operation (#10201)
  docs: Update credential urls (no-changelog) (#10193)
  fix(editor): Add back prompt requesting to save unsaved changes (no-changelog) (#10190)
  fix(HTTP Request Node): Resolve max pages expression (#10192)
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants