Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Wise Node): Use ISO formatting for timestamps #10288

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

mocanew
Copy link
Contributor

@mocanew mocanew commented Aug 2, 2024

Summary

Using Wise node's get many transfers functionality generates a 422 Unprocessable Entity error from the Wise API due to the date fields being formatted as 2024-07-02T15:10:15+00:00 instead of 2024-07-02T15:10:15Z. This PR fixes this issue.

Related Linear tickets, Github issues, and Community forum posts

I've not opened an issue for this. I had to solve this issue for our internally deployed n8n and wanted to contribute back.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Aug 2, 2024
@mocanew mocanew changed the title fix Wise Node: Use ISO formatting for timestamps fix(Wise Node): Use ISO formatting for timestamps Aug 2, 2024
@netroy
Copy link
Member

netroy commented Aug 3, 2024

for posterity, can you please link to Wise docs that say that these timestamps need to be at UTC? 🙏🏽

@mocanew
Copy link
Contributor Author

mocanew commented Aug 3, 2024

Here's the Wise docs link. They don't explicitly say it's UTC only, but the format yyyy-mm-ddThh:mm:ss.sssZ (for createdDateStart and createdDateEnd) implies timezone offsets are not supported.

Regardless of the timezone part, the current date format is not supported. Since this functionality has worked in the past, I suspect a Moment.js update changed the default formatting.

@webkp
Copy link
Contributor

webkp commented Jan 6, 2025

Thank you @mocanew for raising the issue. I ran into it today as well and was glad I found the reason here. Do you know when this fix will be released @netroy ?

@Joffcom Joffcom added the tests-needed This PR needs additional tests label Jan 20, 2025
@webkp
Copy link
Contributor

webkp commented Jan 30, 2025

Only a friendly reminder. Sorry for being so persistent @Joffcom, I'm sure you have a lot to do, but without this fix I can't complete a pending accounting integration with Wise. Thank you for all the great work.

@netroy netroy merged commit 1a2d39a into n8n-io:master Feb 3, 2025
19 checks passed
@Joffcom
Copy link
Member

Joffcom commented Feb 3, 2025

Hey @mocanew & @webkp,

This will be in this weeks release.

@janober
Copy link
Member

janober commented Feb 6, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released tests-needed This PR needs additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants