Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Git) "Disable ceritificate check" option #10289

Closed

Conversation

salehjafarli
Copy link

@salehjafarli salehjafarli commented Aug 3, 2024

Summary

This pr adds new Disable certificate check boolean option to Git node to disable ssl verification.

Note: I have noticed that Git addConfig option already helps to add key value git configuration to given repository. Unfortunately Git addConfig option doesn't help me during cloning operation because repository hasn't been created yet.

Please lmk if this change is okay, so i can provide tests

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@salehjafarli salehjafarli changed the title feat(Git) Disable ceritificate check option feat(Git) "Disable ceritificate check" option Aug 3, 2024
@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Aug 3, 2024
@CLAassistant
Copy link

CLAassistant commented Aug 3, 2024

CLA assistant check
All committers have signed the CLA.

@netroy
Copy link
Member

netroy commented Aug 3, 2024

Can you please update the description to add more info about what problem this is trying to solve, and if any other users have reported this as a problem?

@salehjafarli
Copy link
Author

salehjafarli commented Aug 3, 2024

Can you please update the description to add more info about what problem this is trying to solve, and if any other users have reported this as a problem?

Hi, I want to be able to disable ssl certificate checks just like I can do it with http request node. I have tried to use addConfig option but that requires git repository and that adds config only for given repository but I need this during git clone.

@Joffcom
Copy link
Member

Joffcom commented Aug 5, 2024

@salehjafarli
Copy link
Author

@salehjafarli does this not help?

https://docs.n8n.io/hosting/configuration/configuration-examples/custom-certificate-authority/

Hi @Joffcom. I appreciate your answer, but the deal is I don't have certificate file to add it to certificate store that's why I want to ignore certificate check.

@netroy
Copy link
Member

netroy commented Aug 5, 2024

I don't have certificate file to add it to certificate store

You don't need the private cert, you only need the public key, which can be extracted using openssl s_client -showcerts

@salehjafarli
Copy link
Author

@netroy, thanks i will be closing the pull request then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants