-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Git) "Disable ceritificate check" option #10289
Conversation
Can you please update the description to add more info about what problem this is trying to solve, and if any other users have reported this as a problem? |
Hi, I want to be able to disable ssl certificate checks just like I can do it with http request node. I have tried to use addConfig option but that requires git repository and that adds config only for given repository but I need this during git clone. |
Hi @Joffcom. I appreciate your answer, but the deal is I don't have certificate file to add it to certificate store that's why I want to ignore certificate check. |
You don't need the private cert, you only need the public key, which can be extracted using |
@netroy, thanks i will be closing the pull request then. |
Summary
This pr adds new
Disable certificate check
boolean option to Git node to disable ssl verification.Note: I have noticed that Git addConfig option already helps to add key value git configuration to given repository. Unfortunately Git addConfig option doesn't help me during cloning operation because repository hasn't been created yet.
Please lmk if this change is okay, so i can provide tests
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)