Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Standardize MFA code and recovery code naming across code base #12011

Merged
merged 4 commits into from
Dec 3, 2024
Merged

refactor: Standardize MFA code and recovery code naming across code base #12011

merged 4 commits into from
Dec 3, 2024

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Dec 2, 2024 •
edited
Loading

Summary

This PR extracts the renaming from #12013

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title standardize MFA code and recovery code naming across code base refactor(editor): standardize MFA code and recovery code naming across code base Dec 2, 2024
@RicardoE105 RicardoE105 changed the title refactor(editor): standardize MFA code and recovery code naming across code base refactor(editor): Standardize MFA code and recovery code naming across code base Dec 2, 2024
@RicardoE105 RicardoE105 changed the title refactor(editor): Standardize MFA code and recovery code naming across code base refactor: Standardize MFA code and recovery code naming across code base Dec 2, 2024
@RicardoE105 RicardoE105 requested a review from tomi December 2, 2024 17:29
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 2, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.19718% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/api/mfa.ts 0.00% 6 Missing ⚠️
...ackages/editor-ui/src/components/MfaSetupModal.vue 0.00% 4 Missing ⚠️
...ackages/editor-ui/src/views/ChangePasswordView.vue 0.00% 4 Missing ⚠️
packages/cli/src/controllers/mfa.controller.ts 80.00% 1 Missing and 1 partial ⚠️
packages/editor-ui/src/api/users.ts 0.00% 2 Missing ⚠️
packages/editor-ui/src/stores/users.store.ts 66.66% 2 Missing ⚠️
packages/editor-ui/src/views/SigninView.vue 60.00% 2 Missing ⚠️
...s/cli/src/controllers/password-reset.controller.ts 66.66% 1 Missing ⚠️
...mponents/PromptMfaCodeModal/PromptMfaCodeModal.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@RicardoE105 RicardoE105 mentioned this pull request Dec 2, 2024
Merged
4 tasks
@RicardoE105 RicardoE105 force-pushed the standardize-mfa-code-naming branch from 5d50809 to 3cae778 Compare December 2, 2024 20:11
@RicardoE105 RicardoE105 mentioned this pull request Dec 2, 2024
Merged
4 tasks
tomi
tomi previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this 💟

packages/cli/src/controllers/auth.controller.ts Outdated Show resolved Hide resolved
@RicardoE105 RicardoE105 requested a review from tomi December 2, 2024 20:37
tomi
tomi approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cypress Cypress
Copy link

cypress bot commented Dec 3, 2024

n8n    Run #8190

Run Properties:  status check passed Passed #8190  •  git commit a7902847e5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review standardize-mfa-code-naming
Run status status check passed Passed #8190
Run duration 04m 29s
Commit git commit a7902847e5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 70706d8 into master Dec 3, 2024
47 checks passed
@RicardoE105 RicardoE105 deleted the standardize-mfa-code-naming branch December 3, 2024 12:15
@janober
Copy link
Member

janober commented Dec 4, 2024

Got released with [email protected]

riascho pushed a commit that referenced this pull request Jan 14, 2025
@RicardoE105 @riascho
refactor: Standardize MFA code and recovery code naming across code b…
ffc747a 
…ase (#12011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RicardoE105 @janober @tomi