-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis node get not editing items #121
Conversation
Florian GAULTIER seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Thanks a lot for reporting the issue! However, had to fix that a little bit differently. Return now the items like they were supposed to. The reason why I could not accept your PR is that it changes the incoming data which is not allowed. It is described here: If it does not describe good enough please simply get back to me. Thanks for your help! |
Oh ok, will keep this in mind. I did agix@62d50cb but I just saw you already fixed it. |
Sorry for the unnecessary work. Was probably not making it very clear that I had fixed it. |
No problem :) thank you very much for your quick fix ! |
When using redis node with
Get
orKeys
operation
,propertyName
is not populated.An
item
variable is created with emptyjson
attribute which is then populated onpropertyName
. But this variabe is never used later.I don't understand why this variable exist so I removed it and directly edit
items[itemIndex]
.